- Jun 21, 2023
-
-
Jed Fox authored
None of this code is relevant to people who have used the open source app. I initially wanted to leave it in so it could be used for major new features in the future, but as it falls further and further out of date I think it’s best to just delete it in a clean PR that can be referenced later if desired.
-
- Jun 20, 2023
-
-
Matiss Janis Aboltins authored
Closes #1069 I've not actually tested this change. Which is why I'm not changing it to direct links (as they might not work). Instead I'm just applying a very quick patch so the message would not be misleading anymore.
-
Jed Fox authored
It now always shows a menu, so the user doesn’t unexpectedly perform an action.
-
Joel Jeremy Marquez authored
This PR is for the first item listed in #559: `Expand All / Collapse All Categories` For the expand / collapse all categories functionality, I was choosing between having a single `Expand / collapse all categories` button or one for each: `Expand all categories` and `Collapse all categories` buttons. For the initial implementation, I have opted with the latter. Please let me know which one is the right way to go or if there are other suggestions and I'll just accordingly. 
-
Matiss Janis Aboltins authored
-
- Jun 17, 2023
-
-
Shazib Hussain authored
-
Shazib Hussain authored
Continuing on from #1139 this PR deletes all function that are not used anywhere. The next PR will include all the entire files that are unused & deleted.
-
- Jun 16, 2023
-
-
Jed Fox authored
This reverts #1029. As raised in #1097, the formatting chosen doesn’t work well when doing math. There may be a way to balance compatibility with multiple format styles with handling non-currency amounts correctly, but it will require some more careful consideration. Re-opens #894.
-
Jed Fox authored
-
- Jun 15, 2023
-
-
Shazib Hussain authored
As discussed in #1126 creating separate PRs. The linter rule isn't actually part of this first PR and will likely be in the final PR as otherwise it will just fail because all the issues aren't resolved. The code is 'ready' though so as soon as this is merged I will open next one(s)
-
Matiss Janis Aboltins authored
Closes #1125 Disables (hides) the "all payees" checkbox when schedules are loading. Reproduction: 1. open `/schedule/discover` 2. while the data is still loading - click on the checkbox in the table header 3. after loading finishes - the page crashes with an error
-
Jed Fox authored
Depends on https://github.com/actualbudget/docs/pull/202.
-
- Jun 14, 2023
-
-
Matiss Janis Aboltins authored
Further Nordigen fixes for expired bank-links. With the recent changes to the router, we had broken this functionality. <img width="488" alt="Screenshot 2023-06-14 at 09 00 21" src="https://github.com/actualbudget/actual/assets/886567/8e7516e0-121a-46e0-9e52-24748b161173"> <img width="437" alt="Screenshot 2023-06-14 at 09 00 30" src="https://github.com/actualbudget/actual/assets/886567/88b36549-1073-4269-b42f-1553c164316f">
-
Matiss Janis Aboltins authored
Fix linking via the account page. Previously it was not fully working if the user had not set up the credentials before. https://github.com/actualbudget/actual/assets/886567/588dc437-b53d-4616-8612-a2ef07445dc8 --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Jun 13, 2023
-
-
Matiss Janis Aboltins authored
Small bugfix for nordigen. Do not perform the server status check if the user is actually offline.
-
- Jun 11, 2023
-
-
Jed Fox authored
Previously, the frontend would attempt to make real requests to `https://not-configured/`, which of course failed. I’ve changed the internal structure to have the lack of a server expressed as a `null` server. A new `did-bootstrap` browser-level setting has been added to track if the user clicked “Don’t use a server.” Finally, I updated the auth logic for methods that call out to the server to make them consistent and use the early return style which reduces indentation.
-
youngcw authored
This adds an option to the month drop down to check all the template lines. If there are errors the offending line is shown with its category. I also modified the wording on the regular template return to be more accurate. Fixes #1100
-
- Jun 09, 2023
-
-
Jed Fox authored
Bundle sizes are unchanged but now we no longer pull in the Electron-specific FS code on the web version
-
- Jun 08, 2023
-
-
Davis Silverman authored
Draft because it is untested, maybe tonight I will test it! Just wanted to get some code out cause i had a spare 5 minutes. The new parser isn't immediately good enough to replace the old parser, and I sadly lost the time to contribute more! Sorry! If someone else wants to take maintenance burden of this code, we can not merge this. Otherwise, it should go the way of the Dodo it seems. Thanks! Closes #1044
-
- Jun 06, 2023
-
-
Jed Fox authored
Closes #944, closes #532. ~WIP because something is causing the test budget to fail to create because it’s using INSERT instead of UPDATE sql queries. (Or not? I have no idea)~
-
- Jun 05, 2023
-
-
SudoCerb authored
-
- Jun 04, 2023
- Jun 01, 2023
-
-
Matiss Janis Aboltins authored
Web: https://github.com/actualbudget/actual/pull/1087 Server: https://github.com/actualbudget/actual-server/pull/207 Docs: https://github.com/actualbudget/docs/pull/179 --------- Co-authored-by:
Jed Fox <git@jedfox.com> Co-authored-by:
github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
-
Tom French authored
-
Matiss Janis Aboltins authored
-
- May 30, 2023
-
-
shall0pass authored
~This is really just a proof of concept. I have no delusions that this might get included. I'm sure others might have a much cleaner implementation.~ I'm now delusional. Resolves https://github.com/actualbudget/actual/issues/508 Taking @youngcw 's advice, I changed the keyword to #cleanup for the end of month script to keep it separated. This screen video shows two categories that are sources of funds. At the end of the month, any excess in these funds can be redistributed to your highest priorities. Three categories are set as sinks, or recipients, of excess funds. #cleanup source -> Move 'extra' funds to To Budget #cleanup sink -> Fund category with To Budget funds, default weight = 1 #cleanup sink 2 -> Fund category with To Budget funds, weight = 2 Steps of the script: 1. Return funds from any category marked 'source' 2. Fund overspent categories fully if negative carryover is not allowed. 3. Fund each 'sink' category by the desired weight. I run through the script twice. Once to show that if there is a debt category that has a rolling negative balance, it will skip funding that category first and once to show how if a rolling negative balance isn't allowed, it will fund it before applying the weighted remainder. The example shown uses weights of 60, 20, and 20; therefore, the Debt category will receive 60% of the To Budget funds while General and Bills receive 20% each. The weights could have been changed to 6, 2, and 2 or 3 for the Debt category with no additional value for General and Bills to achieve the same result. 
-
- May 29, 2023
-
-
Jed Fox authored
- Enforce that imports from the same package are merged into a single import - In `loot-core`, require that imports of other `loot-core` files use a relative import (like the vast majority of such imports) rather than specifiers starting with `loot-core/` (probably a result of moving files out of other packages into `loot-core`)
-
- May 28, 2023
-
-
Jed Fox authored
-
- May 27, 2023
-
-
Jack authored
-
- May 25, 2023
-
-
Jed Fox authored
-
- May 21, 2023
-
-
Jack authored
Fixed a bug where it was possible to make a transfer to the same account as the one making the transfer. (#1038) The payee autocomplete was always using cached accounts. Added a check to see if accounts was already passed in as a parameter - only using cached if it wasnt.
-
- May 20, 2023
-
-
Trevor Farlow authored
-
Jed Fox authored
-
chylex authored
-
- May 18, 2023
-
-
Shazib Hussain authored
Updates to the latest version of electron and moves the backend-frontend communication from node-ipc to websockets. This resolves the previous roadblock regarding `nodeIntegration` . Done - Remove node-ipc in favour of websockets. - Move file copying out of `preload.js` to avoid importing module `fs` there - Bump all electron pacakge versions to the latest - Added new package for finding open ports as node-ipc is gone - Tweaked webpack config for above changes Partially fixes #468 Questions/ Pending: - Literally every single test fails for me, presumably some issue with my setup/environment. - The websocket communication is not using TLS. I'm not sure how to enable this, or if we even need to as its all local. - Still need to create the CI for building/deploying but I'm not sure where start in this regard as i have no exp with it. Presumably we will need to point the electron auto-updater to the github releases url's. If people are happy with this PR I will look at adding the CI before its merged. - In dev mode only, I have disabled TLS security becuase my docker container's cert is not signed. I _assume_ this will be true for other people who spin up the server on thier own hardware. Perhaps I just need to change my cert to one from letsencrypt or something... Notes. I have not touched javascript in eons so my apologies if the commit trail is a bit fragmented. I tried to keep them fairly contained and then there is a slightly gnarly final commit fixing all the linter issues... Please let me know if you want me to squash some commits etc. I initially tried to move this to web workers the same way the web app does it but this was unsuccessful. I have found no way to spin up a worker in one place (frontend/backend) and then pass this worker to the other. The electron ipc channels don't allow you to directly pass objects such as workers, everything is cloned/serialised. Passing a port number so the other end can spin up its own socket works fine. --------- Co-authored-by:
Shazib Hussain <contact@shazib.com> Co-authored-by:
Jed Fox <git@jedfox.com>
-
Jed Fox authored
Now we just have one spring animation library
-
- May 17, 2023
-
-
Alberto Gasparin authored
Another batch of components in `desktop-client` converted to TS
-
Trevor Farlow authored
Introduces a **ResponsiveProvider** as the sole location that tracks window size and makes that info available to the entire app. This can be used for media queries and size-based component switching. --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
- May 16, 2023
-
-
Jed Fox authored
-