chore: migrate some JS to TS (#1078)

packages/desktop-client/src/hooks/useLatestVersion.js → packages/desktop-client/src/hooks/useLatestVersion.ts

@@ -2,7 +2,7 @@ import { useState, useEffect } from 'react';
 
 import { getIsOutdated, getLatestVersion } from '../util/versions';
 
-function useIsOutdated() {
+function useIsOutdated(): boolean {
   let [isOutdated, setIsOutdated] = useState(false);
   const latestVersion = useLatestVersion();
 
@@ -15,7 +15,7 @@ function useIsOutdated() {
   return isOutdated;
 }
 
-function useLatestVersion() {
+function useLatestVersion(): string {
   let [latestVersion, setLatestVersion] = useState('');
   useEffect(() => {
     (async () => {

packages/desktop-client/src/hooks/useResizeObserver.js → packages/desktop-client/src/hooks/useResizeObserver.ts

 import { useRef, useCallback } from 'react';
 
-export default function useResizeObserver(func) {
+export default function useResizeObserver(
+  func: (contentRect: DOMRectReadOnly) => ResizeObserver,
+): (el: unknown) => void {
   let observer = useRef(null);
   if (!observer.current) {
     observer.current = new ResizeObserver(entries => {

packages/desktop-client/src/hooks/useSyncServerStatus.js → packages/desktop-client/src/hooks/useSyncServerStatus.ts

@@ -2,7 +2,9 @@ import { useSelector } from 'react-redux';
 
 import { useServerURL } from '../components/ServerContext';
 
-export default function useSyncServerStatus() {
+type SyncServerStatus = 'offline' | 'no-server' | 'online';
+
+export default function useSyncServerStatus(): SyncServerStatus {
   const serverUrl = useServerURL();
   const userData = useSelector(state => state.user.data);
 

packages/desktop-client/src/index.js → packages/desktop-client/src/index.tsx

@@ -62,6 +62,17 @@ const boundActions = bindActionCreators(actions, store.dispatch);
 // Listen for global events from the server or main process
 handleGlobalEvents(boundActions, store);
 
+declare global {
+  // eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+  interface Window {
+    __actionsForMenu: typeof actions;
+
+    $send: typeof send;
+    $query: typeof runQuery;
+    $q: typeof q;
+  }
+}
+
 // Expose this to the main process to menu items can access it
 window.__actionsForMenu = boundActions;
 

packages/desktop-client/src/polyfills.js → packages/desktop-client/src/polyfills.ts

-export default async function installPolyfills() {
+export default async function installPolyfills(): Promise<void> {
   if ('ResizeObserver' in window === false) {
     const module = await import('@juggle/resize-observer');
     window.ResizeObserver = module.ResizeObserver;

packages/desktop-client/src/util.js → packages/desktop-client/src/util.ts

-export function getModalRoute(name) {
+export function getModalRoute(name: string): [string, string] {
   let parts = name.split('/');
   return [parts[0], parts.slice(1).join('/')];
 }

packages/desktop-client/src/util/versions.js → packages/desktop-client/src/util/versions.ts

-function parseSemanticVersion(versionString) {
+function parseSemanticVersion(versionString): [number, number, number] {
   return versionString
     .replace('v', '')
     .split('.')
     .map(n => parseInt(n));
 }
 
-export function cmpSemanticVersion(versionStringA, versionStringB) {
+export function cmpSemanticVersion(
+  versionStringA: string,
+  versionStringB: string,
+): number {
   let x = parseSemanticVersion(versionStringA);
   let y = parseSemanticVersion(versionStringB);
 
   return x[0] - y[0] || x[1] - y[1] || x[2] - y[2];
 }
 
-export async function getLatestVersion() {
+export async function getLatestVersion(): Promise<string> {
   let response = await fetch(
     'https://api.github.com/repos/actualbudget/actual/tags',
   );
@@ -23,7 +26,7 @@ export async function getLatestVersion() {
   return tags[tags.length - 1];
 }
 
-export async function getIsOutdated(latestVersion) {
+export async function getIsOutdated(latestVersion: string): Promise<boolean> {
   let clientVersion = window.Actual.ACTUAL_VERSION;
   return cmpSemanticVersion(clientVersion, latestVersion) < 0;
 }

upcoming-release-notes/1078.md

+---
+category: Maintenance
+authors: [TomAFrench]
+---
+
+Migrate some files in `desktop-client` to use Typescript.
\ No newline at end of file