Commits · 4ecb58cd5c5d6387fc5fd654fc6c30ef9db31e6f · danieljk / actual-vt-capstone

May 15, 2023
- Updated account ordering in the account autocomplete popup (#1034) · 4ecb58cd
  Jack authored 1 year ago
  
  Unverified
  
  4ecb58cd
May 10, 2023
- Pull shiftKey state directly from the initiating event (#1022) · e4e9267c
  Jed Fox authored 1 year ago
  
  Fixes #1021
  Unverified
  
  e4e9267c
May 09, 2023
- Fix for issue #319 (#1008) · 8faa7bd6
  TheTrueCaligari authored 1 year ago
  
  Unverified
  
  8faa7bd6
- Migrate top common components to TS (#979) · f618055a
  Alberto Gasparin authored 1 year ago
  
  Unverified
  
  f618055a
May 08, 2023
- (TransactionTable) fix split-transaction focus field (#999) · 24d40706
  Matiss Janis Aboltins authored 1 year ago
  
  Closes #996
  Unverified
  
  24d40706
May 04, 2023
- (transactions) create transaction when clicking enter (#992) · 539cb0e5
  Matiss Janis Aboltins authored 1 year ago
  
  Closes #943 Creates the transaction when clicking "enter". Irrelevant of which field is currently active.
  Unverified
  
  539cb0e5
Apr 30, 2023
- @typescript-eslint/no-unused-vars (#974) · bd14b51e
  Trevor Farlow authored 1 year ago
  
  Switch to TS version of `no-unused-vars` rule.
  Unverified
  
  bd14b51e
Apr 28, 2023
- (transaction-table) show checkbox on hover (#966) · 71908b6f
  Matiss Janis Aboltins authored 1 year ago
  
  Closes #965
  Unverified
  
  71908b6f
- refactor(typescript): move some common components to TS (#962) · 851fa8c7
  Matiss Janis Aboltins authored 1 year ago
  
  Unverified
  
  851fa8c7
Apr 25, 2023
- (schedules) make transfers appear in both accounts (#955) · 4b712699
  Matiss Janis Aboltins authored 1 year ago
  
  Closes #551 Make scheduled transfers appear in both accounts.
  Unverified
  
  4b712699
Apr 21, 2023

Improve sidebar auto-floating behavior (#868) · 944c7ff3

Jed Fox authored 1 year ago

I got some feedback in the discord that this behavior was disruptive
when zooming in.

- I’ve reduced the breakpoint so hopefully the disruption of the
transition is matched by a significant improvement in available space
now.
- Also the 2 places in the app that use window width (including here)
now check for the width of the `<html>` tag, not the width of the
viewport (those 2 values can be different when doing a pinch-zoom,
causing undesirable layout shifts.)
- Most of the logic has been rewritten to improve the transitions

Mobile & desktop experience

https://user-images.githubusercontent.com/25517624/233653721-b13c5e22-ae11-4bdf-a494-a6916556d05e.mov

https://user-images.githubusercontent.com/25517624/233654784-b6cc1006-44ea-4066-be7a-8d0dd786fb5b.mov

(I’d like tapping on something to close the sidebar on mobile, but that
can be approached in a future PR)

Unverified

944c7ff3

Apr 20, 2023
- Fix currencyToInteger returning null when amount is zero (#915) · 131bb867
  Jed Fox authored 1 year ago
  
  Fixes #913. (And probably a few other similar bugs)
  Unverified
  
  131bb867
Apr 19, 2023
- remove new autocomplete experiment (react-select) (#924) · eed097d4
  Matiss Janis Aboltins authored 1 year ago
  
  Removing `react-select` and the new autocomplete. This experiment has failed, so cleaning things up now.
  Unverified
  
  eed097d4
Apr 16, 2023
- Fill category field when selecting 'Create rule' (#886) · 3fb69e1b
  shall0pass authored 1 year ago
  
  Unverified
  
  3fb69e1b
- Fixes Issue 495 Transfer allowed from same account (#902) · 19a8f14a
  biohzrddd authored 1 year ago
  
  Unverified
  
  19a8f14a
Apr 13, 2023
- (mobile) settings page header (#887) · ec3efc71
  Matiss Janis Aboltins authored 1 year ago
  
  Unverified
  
  ec3efc71
Apr 10, 2023

Convert commonjs to esm (#877) · cd00da76

Alberto Gasparin authored 2 years ago

This PR converts everything (aside from electron) from CommonJS to ESM.
It is needed to reduce the changes that will happen during the migration
to Typescript (as TS does not play nice with CJS).

Basically:
- rewrite `require()` to `import`
- rewrite `module.exports` to `exports`
- introduce `ts-node` to run importers so we can convert them to TS too

Lastly, sorry for this larg-ish PR, not my preference but when I tried
to reduce its scope, I would end up with mixed commons/esm that was even
more tricky to handle.

Unverified

cd00da76

Recognize numpad enter key as enter key (#883) · d7d5820c
Jed Fox authored 2 years ago

Unverified

d7d5820c

Apr 09, 2023
- (rules) creation from account page (#882) · 88fb95b2
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  88fb95b2
Apr 06, 2023
- (autocomplete) height of the input box (#862) · 4d0e9cad
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  4d0e9cad
Apr 04, 2023

normalize value when switching between single/multi select (#855) · e23f9d82

Matiss Janis Aboltins authored 2 years ago

Closes #779

Normalize the input value when switching between single/multi select
fields. Most visible when using the "notes" field filter.

Unverified

e23f9d82

Apr 01, 2023
- (autocomplete) remove portal from table view for smoother experience (#839) · 69140d62
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  69140d62
Mar 26, 2023

(e2e) adding onboarding and budget tests (#813) · 649b4c90

Matiss Janis Aboltins authored 2 years ago

Added onboarding and budget e2e tests. Also fixed an issue for
first-time flows using imports: currently people end up with a blank
white screen after importing. Instead they should see the budget table.

Related: https://github.com/actualbudget/actual/issues/583

Unverified

649b4c90

Mar 24, 2023
- Move all loot-design code into desktop-client (#800) · e71d4dc6
  Jed Fox authored 2 years ago
  
  Seems to build fine, will test later.
  Unverified
  
  e71d4dc6
Mar 23, 2023

Allow rules creation from account page (#802) · 605a0d82

Alberto Gasparin authored 2 years ago

Adding a "create rule" menu item in the transactions dropdown to open
the create new rule modal, pre-filled with the payee information.
Fixes #749

Unverified

605a0d82

Mar 21, 2023
- nit: use curly apostrophes throughout the UI (#791) · 3cb18683
  Jed Fox authored 2 years ago
  
  Unverified
  
  3cb18683
Mar 20, 2023

disabling flaky unit test step (#795) · 84cbe6e5

Matiss Janis Aboltins authored 2 years ago

Disabling the flaky unit test step. We should re-enable it eventually,
but right now it just creates unnecessary noise..

Unverified

84cbe6e5

Mar 18, 2023

refactor Nordigen and Category autocomplete usage (#784) · 1df7acdc

Matiss Janis Aboltins authored 2 years ago

The final `Autocomplete` refactors. After this is merged what's
remaining is to do extensive testing and address the bugs in
https://github.com/actualbudget/actual/issues/773

This PR moves `Nordigen` autocomplete to the new one without using a
feature flag. IMO this is a safe change given the simple nature of the
Nordigen autocomplete component.

Unverified

1df7acdc

move all feature flags to use useFeatureFlag hook (#786) · 67c3be97

Matiss Janis Aboltins authored 2 years ago

Refactored all feature flags to use the new `useFeatureFlag` hook.

Also added a new functionality to this feature flag: ability to define
custom "default" value for a feature flag. This will allow us to enable
the new autocomplete component for everyone using Netlify builds
eventually (need to address some issues before doing so).

Unverified

67c3be97

Remove a few unused class components, convert a few components to functions (#783) · 8def8393
Jed Fox authored 2 years ago

Unverified

8def8393

further autocomplete refactors (#778) · c3c2861d

Matiss Janis Aboltins authored 2 years ago

Further iterations on the new autocomplete.

1. Created `AccountAutocomplete`
2. Started using new autocomplete in `GenericInput` (used for notes
field)
3. Extracted common functionality between the three new autocompletes to
a generic component: `Autocomplete`

Unverified

c3c2861d

Improve handling of large currency amounts (#725) · 97b1b6f8

Jed Fox authored 2 years ago

- Add a “hide decimal places” setting to visually hide the `.xx` from
currency values globally
- When hiding the fractional digits, slightly decrease character spacing
to allow more digits to show up

Ref: #327

New settings:
<img width="566" alt="Screenshot_2023-03-17 14 19 46"
src="https://user-images.githubusercontent.com/25517624/225986815-b884b93d-02f9-48b3-a73d-d27f90b678cf.png">


Before/after:
<img width="149" alt="Screenshot_2023-02-27 21 47 07"
src="https://user-images.githubusercontent.com/25517624/222916856-21ab4f03-56c6-4b24-8fc1-ac4b883138b7.png"><img
width="131" alt="Screenshot_2023-02-27 22 02 01"
src="https://user-images.githubusercontent.com/25517624/222916859-cf882ca3-6087-4994-818e-239c3374e412.png">

Unverified

97b1b6f8

change unit test usage of notes field (#780) · 98948744

Matiss Janis Aboltins authored 2 years ago

Added an extra `waitFor` after a flaky unit test step.

I'm not really super happy with this workaround.. but it does make the
test much more stable (re-ran 5x and no failures:
https://github.com/actualbudget/actual/actions/runs/4455134799).

I think there is some internal timeout happening somewhere which is
causing this issue.. But not really sure where. And this will hopefully
get auto-fixed once we migrate to a new table.

Unverified

98948744

(TransactionsTable) bring back missing onHover (#777) · ce40e61a
Matiss Janis Aboltins authored 2 years ago
```
Brining back `onHover`. This is a small regression.
```
Unverified

ce40e61a

Mar 17, 2023
- (autocomplete) refactor PayeeAutocomplete to react-select (#741) · 141035cd
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  141035cd
- (TransactionsTable) port to react hooks (#769) · 610a044f
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  610a044f
- Update wording across the UI to clarify that we don’t own any servers (#768) · c5c4cbbe
  Jed Fox authored 2 years ago
  
  Unverified
  
  c5c4cbbe
- upgrade React from v16 to v18 (#696) · 5d7ead44
  Matiss Janis Aboltins authored 2 years ago
  
  Unverified
  
  5d7ead44
Mar 16, 2023

making desktop-client tests independent (#765) · d9bc64e7

Matiss Janis Aboltins authored 2 years ago


Tests cases should be independent. You should be able to run them in
whatever order you want. And they should still pass.

Currently this is not the case. The order of the tests is very important
due to the "pseudo" randomization algorithm.

This PR makes the mock data IDs truly unique thus better exposing the
issue in our tests. Also this PR fixes the dependency issues thus making
each test case truly independent.

---------

Co-authored-by: Jed Fox <git@jedfox.com>

Unverified

d9bc64e7

Mar 13, 2023

(nordigen) check server status before linking accs (#742) · 6e7c95b5

Matiss Janis Aboltins authored 2 years ago

Related to:
https://github.com/actualbudget/actual/issues/724#issuecomment-1455160250

Depends on https://github.com/actualbudget/docs/pull/126 to be merged
first.

Two changes here:
1. show "link account" only if actual-server is used (user is "online");
2. allow linking accounts only if Nordigen is configured (using new API
to get the status for it);

Also ported the `CreateAccount` modal to a functional component.

Unverified

6e7c95b5