- Apr 29, 2023
-
-
Alberto Gasparin authored
This is the last PR with lots of renaming for `loot-core`!
-
- Apr 23, 2023
-
-
Aaron Eiche authored
-
Henrik Maaland authored
-
Alberto Gasparin authored
Another batch of `loot-core` migrated.
-
Davis Silverman authored
Hi there, `Peg.js` is unmaintained, so I figure you all would appreciate if I replaced it with the drop-in replacement of Peggy. This is work I am breaking out of #918. Peggy adds new features like source map support that we could use, although I do not include that in this change-set. It may be useful for debugging changes to the .pegjs file we have.e
-
- Apr 22, 2023
-
-
Davis Silverman authored
Hi there, I try to tackle #798 here. It was suggested to throw this behind a feature flag, so here it is! this does its best to import the problem file in #767. I am working on this because it would make my work on #918 easier :) Feel free to set the feature flag to true and try the new importer. The date parser is not as sophisticated as the one in `node-libofx`, but I tried 3 different OFX files, one from my bank, one from the mocks, and one from #767. They all seem to work well enough on that front, but this is definitely the weak point of the new implementation. Let me know what you think!
-
shall0pass authored
This is an initial concept for adding percent based goal targets. This version works by using a string in the form of: #template 10% of Income <- Income is an income category name. Only income category names will work here currently. or #template 10% of all income<- 'all income' is a keyword in this context and will base the calculation on the total income for the month. Some of the nicer touches like Jed's polite notification that the syntax isn't correct is not implemented here yet.
-
shall0pass authored
I've changed the method of calculating the budgeted amount. There may be a more efficient way of writing the loop, so I'm looking forward to the review. This change implements the mathematics of (Target1+Target2+TargetN-Last_months_category_balance) / (MonthsRemaing1 + MonthsRemaining2 + MonthsRemaingN) * N. This is an averaged approach for multiple templates in the same category. It will appear to overbudget or underbudget some months compared to multiple single targets in different categories, yet there should always be enough saved in the category to satisfy the target due. Setting a target, it's assumed that money will be spent in the appropriate month, When a target reaches maturity, the money in the category associated with that target should be spent or moved so the remaining targets continue to be funded. I don't see an easy way of fixing that, but I hope this change will be of some help. Current method: Notice how the Bills (flexible) category reduces each month, resulting in larger budgeted amounts later in the goal cycle.  Proposed method: **Note: The fact that the initial fill in this example equals the expected fill is a coincidence based on the template values I chose. The initial fills can be different from expected fill. 
-
- Apr 20, 2023
-
-
Jed Fox authored
Fixes #913. (And probably a few other similar bugs)
-
- Apr 16, 2023
-
-
Pol Eyschen authored
Co-authored-by:
Jed Fox <git@jedfox.com>
-
biohzrddd authored
-
- Apr 13, 2023
-
-
shall0pass authored
This improves the error reporting when issues are found with Goal Templates. Before these changes, the only error that would be reported is the "Bills" error in the image while the other issues would be ignored and not funded.
-
- Apr 12, 2023
-
-
Jed Fox authored
It turns out this command is not installed by default on macOS. Fortunately the code doesn’t really require it to be used.
-
Alberto Gasparin authored
Another batch of files from `loot-core` migrated to TS (loose mode)
-
shall0pass authored
Resolves issue https://github.com/actualbudget/actual/issues/888
-
- Apr 10, 2023
-
-
Alberto Gasparin authored
This PR converts everything (aside from electron) from CommonJS to ESM. It is needed to reduce the changes that will happen during the migration to Typescript (as TS does not play nice with CJS). Basically: - rewrite `require()` to `import` - rewrite `module.exports` to `exports` - introduce `ts-node` to run importers so we can convert them to TS too Lastly, sorry for this larg-ish PR, not my preference but when I tried to reduce its scope, I would end up with mixed commons/esm that was even more tricky to handle.
-
- Apr 09, 2023
-
-
Jed Fox authored
These files will be automatically recreated by `yarn build:api`, `yarn build:browser`, and `yarn start:browser`, so we don’t need them in the repo.
-
- Apr 07, 2023
-
-
Jakub Kuczys authored
Fixes #840 by creating application-defined SQL functions (https://www.sqlite.org/appfunc.html) for Unicode-aware implementations of `LOWER()` and `UPPER()`. This uses `String.prototype.toLower/UpperCase()` JS method. I initially wanted to just redefine `LOWER()` and `UPPER()` but due to [sql.js not supporting the definition of deterministic functions](https://github.com/sql-js/sql.js/issues/551), I had to just define them as separate functions and use that in the appropriate places. It's probably better like that anyway...
-
shall0pass authored
I believe this change allows for having multiple 'by' rules in the same category. It seems to be working well for my purposes, but I would appreciate further testing to assure there aren't regressions. Example: #template 300 by 2023-06 #template 3000 by 2023-08 Before this PR, having these two lines in the notes would only budget funds for the earliest of the two strings and ignore the 3000 funding target. With this PR, the sum of the two funding targets will be respected.
-
- Apr 06, 2023
-
-
Jed Fox authored
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
-
- Apr 04, 2023
-
-
Matiss Janis Aboltins authored
Closes #764 Dismiss the update notification only after clicking "close" button
-
- Apr 03, 2023
-
-
Jed Fox authored
Previously, we were using an alpha version of date-fns v2. Now we’re using the latest stable v2.
-
Alberto Gasparin authored
Part 1 of the conversion. Mostly renaming js to ts and making sure things make still sense. Added also handy TS ESLint rules. In order to support the various .web/.electron/... I ended up adopting `index.d.ts` as pattern to share type definition. Let me know if that makes sense for you too. Right now the function type definition is duplicated, but the solution will be importing from `index.d.ts` and using `const fn: FnDef = () => ...` that way we can keep all variants in sync from a single type file. Such rewrite however is better done in another PR otherwise we risk confusing git and loosing history (rename + too many changes). Another thing that might do in the next PR is convert all files to ESModules, as things get confusing between CJS exports, ESM default/named and TS adds extra complains.
-
- Mar 29, 2023
-
-
Alberto Gasparin authored
-
- Mar 28, 2023
-
-
Alberto Gasparin authored
-
- Mar 27, 2023
-
-
Jed Fox authored
-
- Mar 26, 2023
-
-
Matiss Janis Aboltins authored
Added onboarding and budget e2e tests. Also fixed an issue for first-time flows using imports: currently people end up with a blank white screen after importing. Instead they should see the budget table. Related: https://github.com/actualbudget/actual/issues/583
-
- Mar 24, 2023
-
-
Aidan Harbison authored
- When parsing an amount string, consider surrounding parentheses to mean the amount is negative. - Ensures all input to `parseFloat()` is sanitized. Closes: #807
-
Jed Fox authored
Seems to build fine, will test later.
-
- Mar 21, 2023
-
-
Jed Fox authored
-
Jakub Kuczys authored
I'm not sure if this is something you want but it was a simple change so I figured I might as well contribute it. This PR allows the user to upload `.blob` files that they may have gotten from server's `user-files/` folder. This can be useful if the user didn't export the file but has server backups. --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Mar 20, 2023
-
-
Matiss Janis Aboltins authored
Depends on server change: https://github.com/actualbudget/actual-server/pull/168
-
- Mar 18, 2023
-
-
Jed Fox authored
- Add a “hide decimal places” setting to visually hide the `.xx` from currency values globally - When hiding the fractional digits, slightly decrease character spacing to allow more digits to show up Ref: #327 New settings: <img width="566" alt="Screenshot_2023-03-17 14 19 46" src="https://user-images.githubusercontent.com/25517624/225986815-b884b93d-02f9-48b3-a73d-d27f90b678cf.png"> Before/after: <img width="149" alt="Screenshot_2023-02-27 21 47 07" src="https://user-images.githubusercontent.com/25517624/222916856-21ab4f03-56c6-4b24-8fc1-ac4b883138b7.png"><img width="131" alt="Screenshot_2023-02-27 22 02 01" src="https://user-images.githubusercontent.com/25517624/222916859-cf882ca3-6087-4994-818e-239c3374e412.png">
-
Jed Fox authored
I noticed that the first run flow is suboptimal for people who want to import an existing file from Actual/YNAB. I’ve moved the welcome modal into the management app and set it up to appear when there are no budgets available (which also has the benefit of allowing people to see the modal again!) I think there’s some weirdness around getting the modal to reappear when deleting a budget file which I want to work out before merging this. This PR also reorganizes the management app a bit to reduce usage of modals (currently, hitting escape while the budget list is open leaves you with a blank page). <img width="539" alt="Screenshot_2023-03-18 08 53 54" src="https://user-images.githubusercontent.com/25517624/226107462-b2b88791-1015-4397-b290-c64e7fcc0f41.png"> - [x] Ensure modal consistently appears when needed (no longer a modal!) - [x] Fix e2e tests
-
- Mar 17, 2023
-
-
Matiss Janis Aboltins authored
Upgraded `fast-check` to improve unit test performance.
-
Matiss Janis Aboltins authored
This is not a full fix for the flakiness. One of the test cases will still be flaky. But at least this fixes the other test cases thus improving stability.
-
Jed Fox authored
-
- Mar 16, 2023
-
-
Matiss Janis Aboltins authored
Removing - Debugger - `perf-deeets` - `codemirror`
-
- Mar 14, 2023
-
-
Jed Fox authored
-
Jed Fox authored
Thanks @kidglove57 for spotting this issue and helping me track down the cause! --------- Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv>
-