Skip to content
Snippets Groups Projects
  1. Jun 19, 2023
  2. Jun 18, 2023
  3. Jun 17, 2023
  4. Jun 16, 2023
  5. Jun 15, 2023
  6. Jun 11, 2023
    • Jed Fox's avatar
      Fix sync-related errors that show up in the console when not using a server (#984) · 0e2b317e
      Jed Fox authored
      Previously, the frontend would attempt to make real requests to
      `https://not-configured/`, which of course failed. I’ve changed the
      internal structure to have the lack of a server expressed as a `null`
      server. A new `did-bootstrap` browser-level setting has been added to
      track if the user clicked “Don’t use a server.”
      
      Finally, I updated the auth logic for methods that call out to the
      server to make them consistent and use the early return style which
      reduces indentation.
      0e2b317e
    • youngcw's avatar
      Goals: Check template action (#1108) · ded6ee8a
      youngcw authored
      This adds an option to the month drop down to check all the template
      lines. If there are errors the offending line is shown with its
      category.
      
      I also modified the wording on the regular template return to be more
      accurate. Fixes #1100
      ded6ee8a
  7. Jun 09, 2023
  8. Jun 08, 2023
    • Davis Silverman's avatar
      Remove 'new' OFX parser as it is too buggy (#1111) · 87d269ba
      Davis Silverman authored
      Draft because it is untested, maybe tonight I will test it! Just wanted
      to get some code out cause i had a spare 5 minutes.
      
      The new parser isn't immediately good enough to replace the old parser,
      and I sadly lost the time to contribute more! Sorry! If someone else
      wants to take maintenance burden of this code, we can not merge this.
      Otherwise, it should go the way of the Dodo it seems.
      
      Thanks!
      
      Closes #1044
      87d269ba
  9. Jun 06, 2023
    • Jed Fox's avatar
      Remove account types (#948) · a25327d3
      Jed Fox authored
      Closes #944, closes #532. ~WIP because something is causing the test
      budget to fail to create because it’s using INSERT instead of UPDATE sql
      queries. (Or not? I have no idea)~
      a25327d3
    • youngcw's avatar
      Goals: Remainder option (#1101) · ed285e9a
      youngcw authored
      Added the option to add a remainder goal template. This will use the
      remaining available funds and dump them into the respective category.
      There is optional weighting. The remainder templates will be forced to
      the lowest priority as to run after all other templates.
      
      Usage: `#template remainder <weight>` Add the template line to any
      categories you want to catch any remaining funds such as savings. The
      amount added to the category will equal
      `remaining_budget/total_of_weights*weight`. The default weight is 1.
      ed285e9a
  10. Jun 04, 2023
    • Shazib Hussain's avatar
      More Electron fixes (#1099) · be810916
      Shazib Hussain authored
      - Fix socket connection issues when reloading
      - Fix external url clicking & middle clicking internal links
      - Remove broken menu option. Easier for now than refactoring the
      settings panel it now lives in. We can add it back later if needed?
      be810916
    • Jed Fox's avatar
      Add clear error to API when no budget is open (#1073) · e1f7262f
      Jed Fox authored
      Previously, this would fail with a confusing “cannot read property of
      `undefined`” error.
      e1f7262f
  11. Jun 03, 2023
  12. Jun 02, 2023
  13. Jun 01, 2023
  14. May 30, 2023
    • shall0pass's avatar
      Goals: Schedule include spent value in calculation (#1049) · bb1a4747
      shall0pass authored
      
      This adds back the functionality, which was inadvertantly removed, that
      includes the already spent column in the calculation when the template
      is run.
      
      Some transactions may be posted to the account prior to running the
      templates and would result incorrect budgeted amounts.
      
      ---------
      
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      bb1a4747
    • shall0pass's avatar
      End of month cleanup script (#1016) · d6408599
      shall0pass authored
      ~This is really just a proof of concept. I have no delusions that this
      might get included. I'm sure others might have a much cleaner
      implementation.~
      I'm now delusional.
      
      Resolves https://github.com/actualbudget/actual/issues/508
      
      Taking @youngcw 's advice, I changed the keyword to #cleanup for the end
      of month script to keep it separated.
      
      This screen video shows two categories that are sources of funds. At the
      end of the month, any excess in these funds can be redistributed to your
      highest priorities. Three categories are set as sinks, or recipients, of
      excess funds.
      
      #cleanup source   -> Move 'extra' funds to To Budget
      #cleanup sink -> Fund category with To Budget funds, default weight = 1
      #cleanup sink 2       -> Fund category with To Budget funds, weight = 2
      
      Steps of the script:
      1. Return funds from any category marked 'source'
      2. Fund overspent categories fully if negative carryover is not allowed.
      3. Fund each 'sink' category by the desired weight.
      
      I run through the script twice. Once to show that if there is a debt
      category that has a rolling negative balance, it will skip funding that
      category first and once to show how if a rolling negative balance isn't
      allowed, it will fund it before applying the weighted remainder. The
      example shown uses weights of 60, 20, and 20; therefore, the Debt
      category will receive 60% of the To Budget funds while General and Bills
      receive 20% each. The weights could have been changed to 6, 2, and 2 or
      3 for the Debt category with no additional value for General and Bills
      to achieve the same result.
      
      
      ![cleanup_button](https://github.com/actualbudget/actual/assets/20625555/56ae2b29-9be6-4e85-b532-1b05cff7c4c7)
      d6408599
  15. May 29, 2023
    • Jed Fox's avatar
      More import-related ESLint rules (#1070) · e660e1e7
      Jed Fox authored
      - Enforce that imports from the same package are merged into a single
      import
      - In `loot-core`, require that imports of other `loot-core` files use a
      relative import (like the vast majority of such imports) rather than
      specifiers starting with `loot-core/` (probably a result of moving files
      out of other packages into `loot-core`)
      e660e1e7
  16. May 28, 2023
  17. May 27, 2023
  18. May 25, 2023
  19. May 24, 2023
  20. May 20, 2023
  21. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      461132b9
  22. May 17, 2023
  23. May 15, 2023
    • SudoCerb's avatar
      Add “Show unused payees” button (#1011) · 1305335f
      SudoCerb authored
      # Add ability to filter the Manage Payees screen to show orphaned payees
      only.
      
      I aimed to modify as little code as possible - we now have a button on
      the Manage Payees screen that will filter the table to show orphaned
      payees only.
      1305335f
  24. May 13, 2023
    • youngcw's avatar
      Fix infinite loop in repeat goal (#1019) · 54f9b712
      youngcw authored
      I believe I found the infinite loop problem in the repeat goal.  
      
      This doesn't mess things up if you are budgeting the same month that the
      goal starts, that's probably why we didn't see it before.
      
      Side note: The logic always starts at the start date in the template,
      then increments until falling in the right month window. If this
      template gets used for, say, a few years, it will start to bog down the
      processing. If someone has a good quick fix I can add that.
      54f9b712
    • shall0pass's avatar
  25. May 10, 2023
  26. May 09, 2023
    • Alberto Gasparin's avatar
      f618055a
    • Jed Fox's avatar
      Enable 'curly' rule (#1015) · 54fa4bcc
      Jed Fox authored
      Multi-line `if`/`for` statements in JS can be confusing since there
      aren’t braces to indicate which code is enclosed in the statement. I set
      the configuration to `multi-line` to enforce usage of braces for
      multi-line statement bodies, but still allow things like `if (foo)
      return;`. I additionally added the `consistent` option to require braces
      for all elements of an if/else chain if one element has it. As you can
      see, this set of options pretty closely matches the existing code style.
      
      I was going to comment in #1008 about this stylistic change but realized
      that it’s (IMO) a little impolite to ask for code style changes unless
      they can be automatically enforced.
      
      Note that `if (foo) { \n return; \n }` is still valid and won’t be
      collapsed. I tried to automatically collapse all such cases but it was a
      lot of files and I didn’t want to pick out the useful from the useless
      differences.
      54fa4bcc
  27. May 07, 2023
  28. May 05, 2023
  29. May 02, 2023
Loading