- Jun 28, 2023
-
-
Jed Fox authored
This PR moves the size comparison action back to a separate workflow which now uses the `pull_request_target` event. This event is triggered at all the same times as the `pull_request` action, except that the workflow file content comes from the target branch of the PR, and it is run in the context of the repo owning the target branch. Practically, this means that it will still have access to post a comment even if the PR comes from a fork. We don’t want the build actions to be run in a `pull_request_target` workflow because they would get access to the secrets and be able to perform arbitrary actions on the repository, even from fork PRs. See the current version failing here: https://github.com/actualbudget/actual/actions/runs/5395184895/jobs/9797388016?pr=1122
-
Jed Fox authored
-
Jed Fox authored
-
- Jun 27, 2023
-
-
Jed Fox authored
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
-
Jed Fox authored
-
Jed Fox authored
This cleans up all of the usage of `<a>` in the codebase. Now all external links get the appropriate attributes added.
-
- Jun 26, 2023
-
-
Jed Fox authored
This significantly speeds up `yarn lint` for me. It also ensures we’re listing all source files in the project, including the `.eslintrc` files and any other files that may be present.
-
Jed Fox authored
This fixes an error that you’ll see about an unused export if you build before linting.
-
Jed Fox authored
This will reduce install/lockfile size but won’t affect the built bundle size. Still nice, hopefully!
-
Jed Fox authored
-
Matiss Janis Aboltins authored
-
Jed Fox authored
I checked through the other references to `navigate` and none of them appeared to be affected.
-
Matiss Janis Aboltins authored
Another monkeypatch bites the dust. AFAIK there is no regression in functionality. But please test yourselves too to double check.
-
- Jun 25, 2023
-
-
Matiss Janis Aboltins authored
It me it seems the monkey patch is no longer necessary.. At least I'm not able to reproduce any `escape` key related issues. But LMK what you think. The `@reach/listbox` component is used for the custom select component (for example: for filters).
-
Matiss Janis Aboltins authored
Just removing some unused/unnecessary scripts and `IS_BETA` env variable + the associated code (we don't use this in the OS version of Actual).
-
shall0pass authored
Based on Tom's comment (https://github.com/actualbudget/actual/pull/1058#issuecomment-1568030881 ) I've eliminated all direct use of date-fns and only use the functions in months.ts. --------- Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv>
-
Jed Fox authored
-
Jed Fox authored
-
Tom French authored
I've updated the return values in `sync/index` to sensible values based on how they're being called. I've updated the type of `msg.value` to be `string | number | null` to match the values expected by `serializeValue`
-
- Jun 24, 2023
-
-
Jed Fox authored
Also remove the need to unmount & remount when switching between accounts. Fixes #1169
-
Joel Jeremy Marquez authored
For #1152
-
Shazib Hussain authored
- New linter rules are now added - Perhaps the `createPayee` method i've tagged with a disable should be deleted. - I have ignored unused methods in Plaid/Mobile as this stuff is still WIP/experimental?
-
Trevor Farlow authored
* Provide `match` prop to class components that still rely on it. * Fixes #1169 * Fixes an unrelated crash on Payees
-
- Jun 23, 2023
-
-
Shazib Hussain authored
Looks like this got missed in the last PR!
-
Trevor Farlow authored
Co-authored-by:
Jed Fox <git@jedfox.com>
-
Shazib Hussain authored
Last one before I add the actual linter rules!
-
Jed Fox authored
-
- Jun 21, 2023
-
-
Jed Fox authored
None of this code is relevant to people who have used the open source app. I initially wanted to leave it in so it could be used for major new features in the future, but as it falls further and further out of date I think it’s best to just delete it in a clean PR that can be referenced later if desired.
-
Matiss Janis Aboltins authored
-
- Jun 20, 2023
-
-
Shazib Hussain authored
Following on from #1146 this PR removes all unused exports from `loot-core/`
-
Matiss Janis Aboltins authored
Closes #1069 I've not actually tested this change. Which is why I'm not changing it to direct links (as they might not work). Instead I'm just applying a very quick patch so the message would not be misleading anymore.
-
Jed Fox authored
It now always shows a menu, so the user doesn’t unexpectedly perform an action.
-
Joel Jeremy Marquez authored
This PR is for the first item listed in #559: `Expand All / Collapse All Categories` For the expand / collapse all categories functionality, I was choosing between having a single `Expand / collapse all categories` button or one for each: `Expand all categories` and `Collapse all categories` buttons. For the initial implementation, I have opted with the latter. Please let me know which one is the right way to go or if there are other suggestions and I'll just accordingly. 
-
Matiss Janis Aboltins authored
-
- Jun 19, 2023
-
-
Jed Fox authored
-
- Jun 18, 2023
-
-
Matiss Janis Aboltins authored
actual-server does not need to import the full actual-app/api package. It can import only the CRDT stuff.. so I'm extracting it into a new package to reduce the size of actual-server and make the link between things more transparent.
-
- Jun 17, 2023
-
-
Shazib Hussain authored
-
Shazib Hussain authored
Continuing on from #1139 this PR deletes all function that are not used anywhere. The next PR will include all the entire files that are unused & deleted.
-
- Jun 16, 2023
-
-
Jed Fox authored
This reverts #1029. As raised in #1097, the formatting chosen doesn’t work well when doing math. There may be a way to balance compatibility with multiple format styles with handling non-currency amounts correctly, but it will require some more careful consideration. Re-opens #894.
-
Jed Fox authored
URLs with the trailing slash don’t work well — requests end up being made to `https://example.com//sync/sync` and such which can 404 --------- Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv>
-