- Jun 04, 2023
-
-
Jed Fox authored
Previously, this would fail with a confusing “cannot read property of `undefined`” error.
-
- Jun 03, 2023
-
-
shall0pass authored
There was one more location where the cleanup script could generate an error. This should fully resolve the error, along with https://github.com/actualbudget/actual/pull/1084.
-
- Jun 02, 2023
-
-
Jed Fox authored
-
- Jun 01, 2023
-
-
shall0pass authored
-
youngcw authored
-
- May 30, 2023
-
-
shall0pass authored
This adds back the functionality, which was inadvertantly removed, that includes the already spent column in the calculation when the template is run. Some transactions may be posted to the account prior to running the templates and would result incorrect budgeted amounts. --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
shall0pass authored
~This is really just a proof of concept. I have no delusions that this might get included. I'm sure others might have a much cleaner implementation.~ I'm now delusional. Resolves https://github.com/actualbudget/actual/issues/508 Taking @youngcw 's advice, I changed the keyword to #cleanup for the end of month script to keep it separated. This screen video shows two categories that are sources of funds. At the end of the month, any excess in these funds can be redistributed to your highest priorities. Three categories are set as sinks, or recipients, of excess funds. #cleanup source -> Move 'extra' funds to To Budget #cleanup sink -> Fund category with To Budget funds, default weight = 1 #cleanup sink 2 -> Fund category with To Budget funds, weight = 2 Steps of the script: 1. Return funds from any category marked 'source' 2. Fund overspent categories fully if negative carryover is not allowed. 3. Fund each 'sink' category by the desired weight. I run through the script twice. Once to show that if there is a debt category that has a rolling negative balance, it will skip funding that category first and once to show how if a rolling negative balance isn't allowed, it will fund it before applying the weighted remainder. The example shown uses weights of 60, 20, and 20; therefore, the Debt category will receive 60% of the To Budget funds while General and Bills receive 20% each. The weights could have been changed to 6, 2, and 2 or 3 for the Debt category with no additional value for General and Bills to achieve the same result. 
-
- May 29, 2023
-
-
Jed Fox authored
- Enforce that imports from the same package are merged into a single import - In `loot-core`, require that imports of other `loot-core` files use a relative import (like the vast majority of such imports) rather than specifiers starting with `loot-core/` (probably a result of moving files out of other packages into `loot-core`)
-
- May 28, 2023
-
-
Jed Fox authored
-
- May 27, 2023
-
-
Jack authored
-
- May 25, 2023
- May 24, 2023
-
-
shall0pass authored
-
youngcw authored
Add option to schedule templates to budget the full amount only in the needed month. Default behavior stays the same of spreading the expense out over the available range. To use the option, use a template like `#template schedule full SCHEDULE_NAME` Also some minor cleanup.
-
- May 20, 2023
-
-
chylex authored
-
- May 18, 2023
-
-
Shazib Hussain authored
Updates to the latest version of electron and moves the backend-frontend communication from node-ipc to websockets. This resolves the previous roadblock regarding `nodeIntegration` . Done - Remove node-ipc in favour of websockets. - Move file copying out of `preload.js` to avoid importing module `fs` there - Bump all electron pacakge versions to the latest - Added new package for finding open ports as node-ipc is gone - Tweaked webpack config for above changes Partially fixes #468 Questions/ Pending: - Literally every single test fails for me, presumably some issue with my setup/environment. - The websocket communication is not using TLS. I'm not sure how to enable this, or if we even need to as its all local. - Still need to create the CI for building/deploying but I'm not sure where start in this regard as i have no exp with it. Presumably we will need to point the electron auto-updater to the github releases url's. If people are happy with this PR I will look at adding the CI before its merged. - In dev mode only, I have disabled TLS security becuase my docker container's cert is not signed. I _assume_ this will be true for other people who spin up the server on thier own hardware. Perhaps I just need to change my cert to one from letsencrypt or something... Notes. I have not touched javascript in eons so my apologies if the commit trail is a bit fragmented. I tried to keep them fairly contained and then there is a slightly gnarly final commit fixing all the linter issues... Please let me know if you want me to squash some commits etc. I initially tried to move this to web workers the same way the web app does it but this was unsuccessful. I have found no way to spin up a worker in one place (frontend/backend) and then pass this worker to the other. The electron ipc channels don't allow you to directly pass objects such as workers, everything is cloned/serialised. Passing a port number so the other end can spin up its own socket works fine. --------- Co-authored-by:
Shazib Hussain <contact@shazib.com> Co-authored-by:
Jed Fox <git@jedfox.com>
-
- May 17, 2023
-
-
Alberto Gasparin authored
Another batch of components in `desktop-client` converted to TS
-
- May 15, 2023
-
-
SudoCerb authored
# Add ability to filter the Manage Payees screen to show orphaned payees only. I aimed to modify as little code as possible - we now have a button on the Manage Payees screen that will filter the table to show orphaned payees only.
-
- May 13, 2023
-
-
youngcw authored
I believe I found the infinite loop problem in the repeat goal. This doesn't mess things up if you are budgeting the same month that the goal starts, that's probably why we didn't see it before. Side note: The logic always starts at the start date in the template, then increments until falling in the right month window. If this template gets used for, say, a few years, it will start to bog down the processing. If someone has a good quick fix I can add that.
-
shall0pass authored
-
- May 10, 2023
-
-
TheTrueCaligari authored
The regex for the "space-dot" format was incorrect. When entering the amount on a schedule, the number was incorrectly read (12.34 became 1234.00) Strangely, it was not an issue with transactions...
-
- May 09, 2023
-
-
Alberto Gasparin authored
-
Jed Fox authored
Multi-line `if`/`for` statements in JS can be confusing since there aren’t braces to indicate which code is enclosed in the statement. I set the configuration to `multi-line` to enforce usage of braces for multi-line statement bodies, but still allow things like `if (foo) return;`. I additionally added the `consistent` option to require braces for all elements of an if/else chain if one element has it. As you can see, this set of options pretty closely matches the existing code style. I was going to comment in #1008 about this stylistic change but realized that it’s (IMO) a little impolite to ask for code style changes unless they can be automatically enforced. Note that `if (foo) { \n return; \n }` is still valid and won’t be collapsed. I tried to automatically collapse all such cases but it was a lot of files and I didn’t want to pick out the useful from the useless differences.
-
- May 07, 2023
-
-
youngcw authored
-
Davis Silverman authored
-
- May 05, 2023
-
-
TheTrueCaligari authored
-
- May 02, 2023
-
-
Jed Fox authored
-
Jed Fox authored
Fixes #615. I would appreciate double-checking that I didn’t accidentally delete anything that is important. Since I’m removing the related API methods, this is technically a breaking change (even if people would have no reason to remove this stuff), so we should probably do a major release of the API package.
-
shall0pass authored
This attempts to add priorities for goal templates and addresses most of https://github.com/actualbudget/actual/issues/959 . I couldn't find a good way to preserve both "Apply" and "Overwrite" operations, so this PR does away with the current "Apply" action behavior. Every box with a budgeted value will be overwritten if a template goal is present. The added syntax to define priorities is as follows: #template -- priority 0, highest priority #template-1 --priority 1, 2nd highest priority #template-2 --priority 2, 3rd highest priority #template-N --priority N, as many as you'd like. ~~Leaving as a draft as this may not be the preferred implementation but I wanted others to be able to try it with netlify.~~ --------- Co-authored-by:
Caleb Young <cwy@rincon.com>
-
- May 01, 2023
-
-
Matiss Janis Aboltins authored
-
- Apr 30, 2023
-
-
Trevor Farlow authored
Switch to TS version of `no-unused-vars` rule.
-
- Apr 29, 2023
-
-
Alberto Gasparin authored
This is the last PR with lots of renaming for `loot-core`!
-
- Apr 23, 2023
-
-
Aaron Eiche authored
-
Henrik Maaland authored
-
Alberto Gasparin authored
Another batch of `loot-core` migrated.
-
Davis Silverman authored
Hi there, `Peg.js` is unmaintained, so I figure you all would appreciate if I replaced it with the drop-in replacement of Peggy. This is work I am breaking out of #918. Peggy adds new features like source map support that we could use, although I do not include that in this change-set. It may be useful for debugging changes to the .pegjs file we have.e
-
- Apr 22, 2023
-
-
Davis Silverman authored
Hi there, I try to tackle #798 here. It was suggested to throw this behind a feature flag, so here it is! this does its best to import the problem file in #767. I am working on this because it would make my work on #918 easier :) Feel free to set the feature flag to true and try the new importer. The date parser is not as sophisticated as the one in `node-libofx`, but I tried 3 different OFX files, one from my bank, one from the mocks, and one from #767. They all seem to work well enough on that front, but this is definitely the weak point of the new implementation. Let me know what you think!
-
shall0pass authored
This is an initial concept for adding percent based goal targets. This version works by using a string in the form of: #template 10% of Income <- Income is an income category name. Only income category names will work here currently. or #template 10% of all income<- 'all income' is a keyword in this context and will base the calculation on the total income for the month. Some of the nicer touches like Jed's polite notification that the syntax isn't correct is not implemented here yet.
-
shall0pass authored
I've changed the method of calculating the budgeted amount. There may be a more efficient way of writing the loop, so I'm looking forward to the review. This change implements the mathematics of (Target1+Target2+TargetN-Last_months_category_balance) / (MonthsRemaing1 + MonthsRemaining2 + MonthsRemaingN) * N. This is an averaged approach for multiple templates in the same category. It will appear to overbudget or underbudget some months compared to multiple single targets in different categories, yet there should always be enough saved in the category to satisfy the target due. Setting a target, it's assumed that money will be spent in the appropriate month, When a target reaches maturity, the money in the category associated with that target should be spent or moved so the remaining targets continue to be funded. I don't see an easy way of fixing that, but I hope this change will be of some help. Current method: Notice how the Bills (flexible) category reduces each month, resulting in larger budgeted amounts later in the goal cycle.  Proposed method: **Note: The fact that the initial fill in this example equals the expected fill is a coincidence based on the template values I chose. The initial fills can be different from expected fill. 
-
- Apr 20, 2023
-
-
Jed Fox authored
Fixes #913. (And probably a few other similar bugs)
-