- Apr 22, 2023
-
-
Davis Silverman authored
Hi there, I try to tackle #798 here. It was suggested to throw this behind a feature flag, so here it is! this does its best to import the problem file in #767. I am working on this because it would make my work on #918 easier :) Feel free to set the feature flag to true and try the new importer. The date parser is not as sophisticated as the one in `node-libofx`, but I tried 3 different OFX files, one from my bank, one from the mocks, and one from #767. They all seem to work well enough on that front, but this is definitely the weak point of the new implementation. Let me know what you think!
-
shall0pass authored
This is an initial concept for adding percent based goal targets. This version works by using a string in the form of: #template 10% of Income <- Income is an income category name. Only income category names will work here currently. or #template 10% of all income<- 'all income' is a keyword in this context and will base the calculation on the total income for the month. Some of the nicer touches like Jed's polite notification that the syntax isn't correct is not implemented here yet.
-
shall0pass authored
I've changed the method of calculating the budgeted amount. There may be a more efficient way of writing the loop, so I'm looking forward to the review. This change implements the mathematics of (Target1+Target2+TargetN-Last_months_category_balance) / (MonthsRemaing1 + MonthsRemaining2 + MonthsRemaingN) * N. This is an averaged approach for multiple templates in the same category. It will appear to overbudget or underbudget some months compared to multiple single targets in different categories, yet there should always be enough saved in the category to satisfy the target due. Setting a target, it's assumed that money will be spent in the appropriate month, When a target reaches maturity, the money in the category associated with that target should be spent or moved so the remaining targets continue to be funded. I don't see an easy way of fixing that, but I hope this change will be of some help. Current method: Notice how the Bills (flexible) category reduces each month, resulting in larger budgeted amounts later in the goal cycle.  Proposed method: **Note: The fact that the initial fill in this example equals the expected fill is a coincidence based on the template values I chose. The initial fills can be different from expected fill. 
-
-
Matiss Janis Aboltins authoredCo-authored-by:
github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Apr 21, 2023
-
-
Jed Fox authored
I got some feedback in the discord that this behavior was disruptive when zooming in. - I’ve reduced the breakpoint so hopefully the disruption of the transition is matched by a significant improvement in available space now. - Also the 2 places in the app that use window width (including here) now check for the width of the `<html>` tag, not the width of the viewport (those 2 values can be different when doing a pinch-zoom, causing undesirable layout shifts.) - Most of the logic has been rewritten to improve the transitions Mobile & desktop experience https://user-images.githubusercontent.com/25517624/233653721-b13c5e22-ae11-4bdf-a494-a6916556d05e.mov https://user-images.githubusercontent.com/25517624/233654784-b6cc1006-44ea-4066-be7a-8d0dd786fb5b.mov (I’d like tapping on something to close the sidebar on mobile, but that can be approached in a future PR)
-
- Apr 20, 2023
-
-
Jed Fox authored
It turns out that `event.key` for ctrl/cmd+Z is `z`, and it’s `Z` for ctrl/cmd+shift+Z. --------- Co-authored-by:Matiss Janis Aboltins <matiss@mja.lv>
-
Jed Fox authored
Fixes #913. (And probably a few other similar bugs)
-
- Apr 19, 2023
-
-
Matiss Janis Aboltins authoredRemoving `react-select` and the new autocomplete. This experiment has failed, so cleaning things up now.
-
Matiss Janis Aboltins authored
-
- Apr 16, 2023
-
-
Pol Eyschen authored
Co-authored-by: -
Matiss Janis Aboltins authored
-
shall0pass authored
-
biohzrddd authored
-
biohzrddd authored
-
- Apr 13, 2023
-
-
shall0pass authored
This improves the error reporting when issues are found with Goal Templates. Before these changes, the only error that would be reported is the "Bills" error in the image while the other issues would be ignored and not funded.
-
Matiss Janis Aboltins authored -
Jed Fox authored
-
- Apr 12, 2023
-
-
Jed Fox authored
It turns out this command is not installed by default on macOS. Fortunately the code doesn’t really require it to be used.
-
Alberto Gasparin authored
Another batch of files from `loot-core` migrated to TS (loose mode)
-
shall0pass authored
Resolves issue https://github.com/actualbudget/actual/issues/888
-
- Apr 11, 2023
-
-
Jed Fox authored
-
- Apr 10, 2023
-
-
Alberto Gasparin authored
This PR converts everything (aside from electron) from CommonJS to ESM. It is needed to reduce the changes that will happen during the migration to Typescript (as TS does not play nice with CJS). Basically: - rewrite `require()` to `import` - rewrite `module.exports` to `exports` - introduce `ts-node` to run importers so we can convert them to TS too Lastly, sorry for this larg-ish PR, not my preference but when I tried to reduce its scope, I would end up with mixed commons/esm that was even more tricky to handle.
-
Jed Fox authored
-
- Apr 09, 2023
-
-
Matiss Janis Aboltins authored -
Matiss Janis Aboltins authored
-
Matiss Janis Aboltins authored
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
-
Jed Fox authored
These files will be automatically recreated by `yarn build:api`, `yarn build:browser`, and `yarn start:browser`, so we don’t need them in the repo.
-
- Apr 07, 2023
-
-
Jakub Kuczys authored
Fixes #840 by creating application-defined SQL functions (https://www.sqlite.org/appfunc.html) for Unicode-aware implementations of `LOWER()` and `UPPER()`. This uses `String.prototype.toLower/UpperCase()` JS method. I initially wanted to just redefine `LOWER()` and `UPPER()` but due to [sql.js not supporting the definition of deterministic functions](https://github.com/sql-js/sql.js/issues/551), I had to just define them as separate functions and use that in the appropriate places. It's probably better like that anyway...
-
Jed Fox authored
-
Jed Fox authored
This should speed up builds in CI, and must not have gotten caught when upgrading `react-scripts`. ref: arackaf/customize-cra#278
-
Matiss Janis Aboltins authored
-
shall0pass authored
I believe this change allows for having multiple 'by' rules in the same category. It seems to be working well for my purposes, but I would appreciate further testing to assure there aren't regressions. Example: #template 300 by 2023-06 #template 3000 by 2023-08 Before this PR, having these two lines in the notes would only budget funds for the earliest of the two strings and ignore the 3000 funding target. With this PR, the sum of the two funding targets will be respected.
-
- Apr 06, 2023
-
-
Matiss Janis Aboltins authored
-
Jed Fox authored
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
-
Matiss Janis Aboltins authored
-
Matiss Janis Aboltins authored -
chris heazlewood authored
-
- Apr 05, 2023
-
-
Matiss Janis Aboltins authored
-
Jed Fox authored
This improves usability of narrow screen widths, and also prepares for further optimizations that would allow us to use the sidebar largely as-is on mobile, instead of having to have a tab bar. --------- Co-authored-by:
-
