- Mar 24, 2023
-
-
Aidan Harbison authored
- When parsing an amount string, consider surrounding parentheses to mean the amount is negative. - Ensures all input to `parseFloat()` is sanitized. Closes: #807
-
Jed Fox authored
Seems to build fine, will test later.
-
- Mar 21, 2023
-
-
Jed Fox authored
-
Jakub Kuczys authored
I'm not sure if this is something you want but it was a simple change so I figured I might as well contribute it. This PR allows the user to upload `.blob` files that they may have gotten from server's `user-files/` folder. This can be useful if the user didn't export the file but has server backups. --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Mar 20, 2023
-
-
Matiss Janis Aboltins authored
Depends on server change: https://github.com/actualbudget/actual-server/pull/168
-
- Mar 18, 2023
-
-
Jed Fox authored
- Add a “hide decimal places” setting to visually hide the `.xx` from currency values globally - When hiding the fractional digits, slightly decrease character spacing to allow more digits to show up Ref: #327 New settings: <img width="566" alt="Screenshot_2023-03-17 14 19 46" src="https://user-images.githubusercontent.com/25517624/225986815-b884b93d-02f9-48b3-a73d-d27f90b678cf.png"> Before/after: <img width="149" alt="Screenshot_2023-02-27 21 47 07" src="https://user-images.githubusercontent.com/25517624/222916856-21ab4f03-56c6-4b24-8fc1-ac4b883138b7.png"><img width="131" alt="Screenshot_2023-02-27 22 02 01" src="https://user-images.githubusercontent.com/25517624/222916859-cf882ca3-6087-4994-818e-239c3374e412.png">
-
Jed Fox authored
I noticed that the first run flow is suboptimal for people who want to import an existing file from Actual/YNAB. I’ve moved the welcome modal into the management app and set it up to appear when there are no budgets available (which also has the benefit of allowing people to see the modal again!) I think there’s some weirdness around getting the modal to reappear when deleting a budget file which I want to work out before merging this. This PR also reorganizes the management app a bit to reduce usage of modals (currently, hitting escape while the budget list is open leaves you with a blank page). <img width="539" alt="Screenshot_2023-03-18 08 53 54" src="https://user-images.githubusercontent.com/25517624/226107462-b2b88791-1015-4397-b290-c64e7fcc0f41.png"> - [x] Ensure modal consistently appears when needed (no longer a modal!) - [x] Fix e2e tests
-
- Mar 17, 2023
-
-
Matiss Janis Aboltins authored
Upgraded `fast-check` to improve unit test performance.
-
Matiss Janis Aboltins authored
This is not a full fix for the flakiness. One of the test cases will still be flaky. But at least this fixes the other test cases thus improving stability.
-
Jed Fox authored
-
- Mar 16, 2023
-
-
Matiss Janis Aboltins authored
Removing - Debugger - `perf-deeets` - `codemirror`
-
- Mar 14, 2023
-
-
Jed Fox authored
-
Jed Fox authored
Thanks @kidglove57 for spotting this issue and helping me track down the cause! --------- Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv>
-
Waseem Hassan Shahid authored
Fixes https://github.com/actualbudget/actual/issues/724#issuecomment-1468453526 And add the missing fallback condition that wasn't catered in https://github.com/actualbudget/actual/pull/745
-
- Mar 13, 2023
-
-
Matiss Janis Aboltins authored
Related to: https://github.com/actualbudget/actual/issues/724#issuecomment-1455160250 Depends on https://github.com/actualbudget/docs/pull/126 to be merged first. Two changes here: 1. show "link account" only if actual-server is used (user is "online"); 2. allow linking accounts only if Nordigen is configured (using new API to get the status for it); Also ported the `CreateAccount` modal to a functional component.
-
Matiss Janis Aboltins authored
Fallback to `bookingDate` if `valueDate` is empty. Fix for: https://github.com/actualbudget/actual/issues/724#issuecomment-1464914546
-
- Mar 12, 2023
-
-
James Long authored
Route aggregate queries in transaction grouped mode through the correct layer to remove deleted transactions (#247) I recently migrated my personal usage of Actual over to the open-source version and imported a bunch of transactions. I have a _lot_ of history in Actual, including a lot of weird edge cases like deleted split transactions. While reconciling I noticed that my account balance shown at the top was incorrect, even though the running balance was current. Digging into this, I discovered that we aren't correctly handling aggregate queries when querying transactions in the "grouped" mode. Aggregate queries don't make sense in the "grouped" mode. Grouped means that you want a list of transactions that include both the parent and child transactions (when they are split). If you are summing up all the amount, you only want to consider non-parent transactions. So we switch it back to "inline" mode, but the way we did this previously was to manually stitch the query together. Even though was add SQL to ignore deleted transactions, we still possibly include them. A child transaction may not be marked as deleted, even though the parent transaction is deleted. When a parent transaction is deleted, all child transactions should be considered deleted as well, regardless of their tombstone status. This is what the `v_transactions_internal_alive` view does. Previously we weren't going through this view though, so we could still potentially include split transactions even though they've been deleted. This is little hacky, but it fixes the immediate problem. We fall back to the inline mode by modifying the where clause, and we also adjust the view that it queries to use the correct one.
-
Jakub Kuczys authored
Try falling back to `remittanceInformationUnstructuredArray.join(', ')` when neither `debtor/creditorName` nor `remittanceInformationUnstructured` fields are present. Addresses a suggestion from https://github.com/actualbudget/actual/issues/724#issuecomment-1464907064
-
Jakub Kuczys authored
Check if the transaction amount is a positive 0 rather than -0. I went for casting the string with `Number` but I could instead replace the whole condition with `!trans.amount.startsWith('-')` or with `trans.amount > 0 || trans.amount == '0.00'` if either of these variants are preferred. Fix for https://github.com/actualbudget/actual/issues/724#issuecomment-1464907064
-
- Mar 09, 2023
-
-
Matiss Janis Aboltins authored
A new release for `api` too so we could start using `better-sqlite3` v8 in `actual-server`.
-
- Mar 08, 2023
-
-
Vincent Schmandt authored
This implements a simple indicator showing the user if the currently used version is outdated by utilising GitHub tags to track the latest version. Closes #463 --------- Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Mar 06, 2023
-
-
Matiss Janis Aboltins authored
Related to: https://github.com/actualbudget/actual-server/pull/144 See the above PR for more details. --- <img width="577" alt="Screenshot 2023-03-05 at 17 54 10" src="https://user-images.githubusercontent.com/886567/222977363-605f8b1e-be7d-4594-93c7-dfaa6cb15ac3.png">
-
- Mar 05, 2023
-
-
Jed Fox authored
-
- Mar 04, 2023
-
-
Filip Stybel authored
* Update gitignore about .idea folder The .idea folder is generated by IntelliJ IDEA * Add integration with Nordigen * Fix linter * Use longer access to the account * Move normalizatoin of accounts to the backend side * Fix possibility to force remove account * Move normalization of transactions to the backend side * Fix Settings.js after merge * fix enableing bank sync * delete old Settings component * Use camelCase for nordigen/remove-account call * WIP refactor * Fix auto-selecting existing accounts * Fix unlinking accounts * Align to backend changes for Nordigen integration * Fix AnimatedLoading * Code review changes * Fix TZ date issue * rm mobile package * rm BankSync settings section * rm console.log * rm comment * applies some alignments from code review * applies some alignments from code review * Add prefix for nordigen specific functionality * Use arrow char * Add prefix for nordigen functionalities * Fix linter * Display only open accounts * Update packages/desktop-client/src/nordigen.js Co-authored-by:
Jed Fox <git@jedfox.com> * Fix incorrect calc of TZ for endDate * Improved error checking * Fix throwing invalid-schema error * Fix for syncing large batches in Safari --------- Co-authored-by:
Filip Stybel <filip.stybel@ynd.co> Co-authored-by:
Leon Ebel <24588023+ebelleon@users.noreply.github.com> Co-authored-by:
Jed Fox <git@jedfox.com>
-
- Mar 02, 2023
-
-
Jed Fox authored
-
- Feb 28, 2023
-
-
Jed Fox authored
* Intelligently adjust field for newly added action * Remove unnecessary switch case * Dedupe list of fields * Remove unnecessary conditionFields prop * Intelligently adjust field for newly added condition * Use a less specific condition
-
Jed Fox authored
* Sort transactions by date in updateCategoryRules * Update better-sqlite3 to 7.5.0 * Update better-sqlite3 to v8
-
Matiss Janis Aboltins authored
*
removed usage of babel-preset-jwl-app * Add @babel/preset-react -
Jed Fox authored
* Run `yarn dedupe` * Update to better-sqlite3@latest * Remove react-native * Remove a bunch more unused deps * Update mitt to 3.0 * Remove a few more * Remove react-native-gesture-handler * Revert "Update to better-sqlite3@latest" This reverts commit d436bc8d73f2745f484def4e40596322d0c56458. * Dedupe better-sqlite3 versions * snapshots! * Fix jsdom error * Revert "Dedupe better-sqlite3 versions" This reverts commit f99d2ab6f9311663e3312ab5b00bc81c068f040d. * Add back jest-watch-typeahead * Fix conflicting Jest version (The jest-environment-jsdom package that is magically available seems to only be compatible with Jest 27)
-
Matiss Janis Aboltins authored
-
- Feb 24, 2023
-
-
Jed Fox authored
-
Jed Fox authored
* Make it easier to build the bundle.api.js for the API * Remove budgetId parameter, move config to top level of API * that’s a breaking change * Add support for signing into the server in init() * Add api.downloadBudget(syncId, { password }) method * Fix lint errors * Refactor: extract out getSyncError * api/download-budget: sync if possible instead of downloading * Don’t bother with fetching remote files and installing key if the file is local * *groupId * FIx lint issues * Remove extra close+reopen * Refactor out duplicate load-budget logic * Trailing commas
-
- Feb 23, 2023
-
-
Jed Fox authored
* Add missing imported_payee case * Switch over to a `switch` to ensure no other cases are missed * Fix switching from “amount” to “amount (inflow/outflow)” * fix crash when parsing null value as number * Fix formatting for “payee/category/account contains” filters
-
- Feb 21, 2023
-
-
Jed Fox authored
* Allow the server to auto-configure the server URL for the client * Extract server URL/version logic out to ensure consistent updates * () * Be more explicit about when the server version is re-fetched * Use a single layer of context provider * Move the bootstrap route to /account/needs-bootstrap * No more `isActual` * Refactor to call subscribe-needs-bootstrap instead of fetch() * Dedupe calls to subscribe-needs-bootstrap * Don’t revalidate the server when we just validated it * simplify * Fix setServerURL
-
Jed Fox authored
* Provide more debugging information when throwing an invalid-schema sync error * Don’t log the errors directly * Update dynamic cell warning to be clearer * rebuild
-
- Feb 15, 2023
-
-
Matiss Janis Aboltins authored
-
- Feb 12, 2023
-
-
Jed Fox authored
* Dedupe loot-core webpack configs * Swap to parsing using Peggy * Actually record syntax errors * Refactor template types * Add notifications after applying the templates * “Successfully” * Try a Nearley grammar * Revert "Try a Nearley grammar" This reverts commit 1e11c07b855a492b905f1291c3eadd93f78ac3de. Not going with this approach since the error messages are inscrutable. * switch to PEG.js which has slightly better tooling support * fix parser * Fix error reporting * Adjust grammar for better error messages Also allow spaces between currency symbol and number * Fix grammar * Make #template prefix case insensitive * Trailing commas * Remove patch-package from loot-core
-
- Feb 10, 2023
-
-
Matiss Janis Aboltins authored
*
(prettier) adding trailing commas * More commas
-
- Feb 09, 2023
-
-
Jed Fox authored
* Allow bypassing SharedArrayBuffer override * Make an attempt to avoid merging budgets * Update FatalError.js * s/allowBuggyFallback/isSharedArrayBufferOverrideEnabled/ Co-Authored-By:
Matiss Janis Aboltins <886567+MatissJanis@users.noreply.github.com> --------- Co-authored-by:
Matiss Janis Aboltins <886567+MatissJanis@users.noreply.github.com>
-
- Feb 05, 2023
-
-
Rich Howell authored
* Remove all references to help@actualbudget.com Replaced help@actualbudget.com with link to GitHub issues * Lint Fixes Lint Fixes * Added React React required for href expansion as per lint rules https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md * Changed links to contact page and fixed linting Changed links to contact page and fixed linting * Update packages/desktop-client/src/components/accounts/AccountSyncCheck.js Co-authored-by:
Jed Fox <git@jedfox.com> * Lint fixes * JSX removal * Lint * Update packages/desktop-client/src/components/tutorial/Final.js Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv> * Update packages/desktop-client/src/components/accounts/AccountSyncCheck.js Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv> * Lint fixes --------- Co-authored-by:
Jed Fox <git@jedfox.com> Co-authored-by:
Matiss Janis Aboltins <matiss@mja.lv>
-