Skip to content
Snippets Groups Projects
Unverified Commit 0baccfd7 authored by Jakub Kuczys's avatar Jakub Kuczys Committed by GitHub
Browse files

:bug: (nordigen) fix detection of -0.00 "debited" transactions (#744)

Check if the transaction amount is a positive 0 rather than -0.
I went for casting the string with `Number` but I could instead replace
the whole condition with `!trans.amount.startsWith('-')` or with
`trans.amount > 0 || trans.amount == '0.00'` if either of these variants
are preferred.

Fix for
https://github.com/actualbudget/actual/issues/724#issuecomment-1464907064
parent b8d7e391
No related branches found
No related tags found
No related merge requests found
......@@ -312,7 +312,10 @@ async function normalizeNordigenTransactions(transactions, acctId) {
}
let payee_name;
if (trans.amount >= 0) {
// When the amount is equal to 0, we need to determine
// if this is a "Credited" or "Debited" transaction. This means
// that it matters whether the amount is a positive or negative zero.
if (trans.amount > 0 || Object.is(Number(trans.amount), 0)) {
const nameParts = [];
nameParts.push(
title(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment