Skip to content
Snippets Groups Projects
  1. May 25, 2023
  2. May 21, 2023
  3. May 20, 2023
  4. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      Unverified
      461132b9
    • Jed Fox's avatar
      Upgrade react-spring, remove wobble (#1043) · 19af0b36
      Jed Fox authored
      Now we just have one spring animation library
      Unverified
      19af0b36
  5. May 17, 2023
  6. May 16, 2023
  7. May 15, 2023
  8. May 10, 2023
  9. May 09, 2023
  10. May 08, 2023
  11. May 05, 2023
  12. May 04, 2023
  13. May 02, 2023
    • Jed Fox's avatar
      Remove unused payee rules feature (#985) · 646d0d90
      Jed Fox authored
      Fixes #615. I would appreciate double-checking that I didn’t
      accidentally delete anything that is important.
      
      Since I’m removing the related API methods, this is technically a
      breaking change (even if people would have no reason to remove this
      stuff), so we should probably do a major release of the API package.
      Unverified
      646d0d90
  14. May 01, 2023
  15. Apr 30, 2023
  16. Apr 29, 2023
  17. Apr 28, 2023
  18. Apr 26, 2023
  19. Apr 25, 2023
  20. Apr 24, 2023
  21. Apr 23, 2023
  22. Apr 22, 2023
    • Davis Silverman's avatar
      Add experimental new OFX importer (#921) · a1d321d6
      Davis Silverman authored
      Hi there, 
      
      I try to tackle #798 here. It was suggested to throw this behind a
      feature flag, so here it is!
      
      this does its best to import the problem file in #767. 
      
      I am working on this because it would make my work on #918 easier :)
      
      Feel free to set the feature flag to true and try the new importer. The
      date parser is not as sophisticated as the one in `node-libofx`, but I
      tried 3 different OFX files, one from my bank, one from the mocks, and
      one from #767. They all seem to work well enough on that front, but this
      is definitely the weak point of the new implementation.
      
      Let me know what you think!
      Unverified
      a1d321d6
Loading