Skip to content
Snippets Groups Projects
  1. Mar 13, 2023
  2. Mar 12, 2023
    • James Long's avatar
      Route aggregate queries in transaction grouped mode through the correct layer... · df8f5853
      James Long authored
      Route aggregate queries in transaction grouped mode through the correct layer to remove deleted transactions (#247)
      
      I recently migrated my personal usage of Actual over to the open-source
      version and imported a bunch of transactions. I have a _lot_ of history
      in Actual, including a lot of weird edge cases like deleted split
      transactions. While reconciling I noticed that my account balance shown
      at the top was incorrect, even though the running balance was current.
      
      Digging into this, I discovered that we aren't correctly handling
      aggregate queries when querying transactions in the "grouped" mode.
      Aggregate queries don't make sense in the "grouped" mode. Grouped means
      that you want a list of transactions that include both the parent and
      child transactions (when they are split). If you are summing up all the
      amount, you only want to consider non-parent transactions. So we switch
      it back to "inline" mode, but the way we did this previously was to
      manually stitch the query together.
      
      Even though was add SQL to ignore deleted transactions, we still
      possibly include them. A child transaction may not be marked as deleted,
      even though the parent transaction is deleted. When a parent transaction
      is deleted, all child transactions should be considered deleted as well,
      regardless of their tombstone status. This is what the
      `v_transactions_internal_alive` view does. Previously we weren't going
      through this view though, so we could still potentially include split
      transactions even though they've been deleted.
      
      This is little hacky, but it fixes the immediate problem. We fall back
      to the inline mode by modifying the where clause, and we also adjust the
      view that it queries to use the correct one.
      df8f5853
    • Jakub Kuczys's avatar
      :bug: (nordigen) fallback to array version of remittanceInformationUnstructured if necessary (#745) · a5a1c81e
      Jakub Kuczys authored
      Try falling back to `remittanceInformationUnstructuredArray.join(', ')`
      when neither `debtor/creditorName` nor
      `remittanceInformationUnstructured` fields are present.
      
      Addresses a suggestion from
      https://github.com/actualbudget/actual/issues/724#issuecomment-1464907064
      a5a1c81e
    • Jakub Kuczys's avatar
      :bug: (nordigen) fix detection of -0.00 "debited" transactions (#744) · 0baccfd7
      Jakub Kuczys authored
      Check if the transaction amount is a positive 0 rather than -0.
      I went for casting the string with `Number` but I could instead replace
      the whole condition with `!trans.amount.startsWith('-')` or with
      `trans.amount > 0 || trans.amount == '0.00'` if either of these variants
      are preferred.
      
      Fix for
      https://github.com/actualbudget/actual/issues/724#issuecomment-1464907064
      0baccfd7
  3. Mar 11, 2023
  4. Mar 09, 2023
  5. Mar 08, 2023
  6. Mar 06, 2023
  7. Mar 05, 2023
  8. Mar 04, 2023
    • Filip Stybel's avatar
      Nordigen integration - account sync (#457) · 5bb4f4b2
      Filip Stybel authored
      
      * Update gitignore about .idea folder
      
      The .idea folder is generated by IntelliJ IDEA
      
      * Add integration with Nordigen
      
      * Fix linter
      
      * Use longer access to the account
      
      * Move normalizatoin of accounts to the backend side
      
      * Fix possibility to force remove account
      
      * Move normalization of transactions to the backend side
      
      * Fix Settings.js after merge
      
      * fix enableing bank sync
      
      * delete old Settings component
      
      * Use camelCase for nordigen/remove-account call
      
      * WIP refactor
      
      * Fix auto-selecting existing accounts
      
      * Fix unlinking accounts
      
      * Align to backend changes for Nordigen integration
      
      * Fix AnimatedLoading
      
      * Code review changes
      
      * Fix TZ date issue
      
      * rm mobile package
      
      * rm BankSync settings section
      
      * rm console.log
      
      * rm comment
      
      * applies some alignments from code review
      
      * applies some alignments from code review
      
      * Add prefix for nordigen specific functionality
      
      * Use arrow char
      
      * Add prefix for nordigen functionalities
      
      * Fix linter
      
      * Display only open accounts
      
      * Update packages/desktop-client/src/nordigen.js
      
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      
      * Fix incorrect calc of TZ for endDate
      
      * Improved error checking
      
      * Fix throwing invalid-schema error
      
      * Fix for syncing large batches in Safari
      
      ---------
      
      Co-authored-by: default avatarFilip Stybel <filip.stybel@ynd.co>
      Co-authored-by: default avatarLeon Ebel <24588023+ebelleon@users.noreply.github.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      5bb4f4b2
  9. Mar 02, 2023
  10. Mar 01, 2023
  11. Feb 28, 2023
  12. Feb 27, 2023
  13. Feb 26, 2023
  14. Feb 25, 2023
  15. Feb 24, 2023
Loading