Skip to content
Snippets Groups Projects
  1. Aug 29, 2023
  2. Aug 25, 2023
  3. Aug 06, 2023
  4. Jul 31, 2023
  5. Jul 20, 2023
  6. Jul 07, 2023
  7. Jul 01, 2023
  8. Jun 28, 2023
  9. Jun 27, 2023
  10. Jun 25, 2023
  11. Jun 21, 2023
  12. Jun 18, 2023
  13. Jun 08, 2023
  14. Jun 01, 2023
  15. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      Unverified
      461132b9
  16. May 16, 2023
  17. May 06, 2023
  18. May 01, 2023
  19. Apr 13, 2023
  20. Apr 07, 2023
  21. Mar 28, 2023
  22. Mar 14, 2023
  23. Mar 06, 2023
  24. Mar 02, 2023
  25. Feb 24, 2023
    • Jed Fox's avatar
      Updates to the @actual-budget/api package (#464) · 93a1f8a9
      Jed Fox authored
      * Make it easier to build the bundle.api.js for the API
      
      * Remove budgetId parameter, move config to top level of API
      
      * that’s a breaking change
      
      * Add support for signing into the server in init()
      
      * Add api.downloadBudget(syncId, { password }) method
      
      * Fix lint errors
      
      * Refactor: extract out getSyncError
      
      * api/download-budget: sync if possible instead of downloading
      
      * Don’t bother with fetching remote files and installing key if the file is local
      
      * *groupId
      
      * FIx lint issues
      
      * Remove extra close+reopen
      
      * Refactor out duplicate load-budget logic
      
      * Trailing commas
      Unverified
      93a1f8a9
  26. Jan 26, 2023
  27. Jan 18, 2023
Loading