Skip to content
Snippets Groups Projects
Unverified Commit 448c4546 authored by Johannes Löthberg's avatar Johannes Löthberg Committed by GitHub
Browse files

Stop setting endDate when fetching GoCardless transactions (#1493)


This breaks fetching transactions where the valueDate is in the future.
While the GoCardless documentation says this should never happen, it's
what happens with at least Bank Norwegian due to them using the interest
date as valueDate.  (C.f. #1392)

Signed-off-by: default avatarJohannes Löthberg <johannes@kyriasis.com>
parent b2738db4
No related branches found
No related tags found
No related merge requests found
...@@ -184,8 +184,6 @@ async function downloadGoCardlessTransactions( ...@@ -184,8 +184,6 @@ async function downloadGoCardlessTransactions(
let userToken = await asyncStorage.getItem('user-token'); let userToken = await asyncStorage.getItem('user-token');
if (!userToken) return; if (!userToken) return;
const endDate = new Date().toISOString().split('T')[0];
const res = await post( const res = await post(
getServer().GOCARDLESS_SERVER + '/transactions', getServer().GOCARDLESS_SERVER + '/transactions',
{ {
...@@ -194,7 +192,6 @@ async function downloadGoCardlessTransactions( ...@@ -194,7 +192,6 @@ async function downloadGoCardlessTransactions(
requisitionId: bankId, requisitionId: bankId,
accountId: acctId, accountId: acctId,
startDate: since, startDate: since,
endDate,
}, },
{ {
'X-ACTUAL-TOKEN': userToken, 'X-ACTUAL-TOKEN': userToken,
......
---
category: Enhancements
authors: [kyrias]
---
Stop setting `endDate` when fetching GoCardless transactions.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment