Skip to content
Snippets Groups Projects
  1. May 28, 2023
  2. May 27, 2023
  3. May 25, 2023
  4. May 24, 2023
  5. May 22, 2023
  6. May 21, 2023
  7. May 20, 2023
  8. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      Unverified
      461132b9
    • Jed Fox's avatar
      Upgrade react-spring, remove wobble (#1043) · 19af0b36
      Jed Fox authored
      Now we just have one spring animation library
      Unverified
      19af0b36
  9. May 17, 2023
  10. May 16, 2023
  11. May 15, 2023
  12. May 13, 2023
    • youngcw's avatar
      Fix infinite loop in repeat goal (#1019) · 54f9b712
      youngcw authored
      I believe I found the infinite loop problem in the repeat goal.  
      
      This doesn't mess things up if you are budgeting the same month that the
      goal starts, that's probably why we didn't see it before.
      
      Side note: The logic always starts at the start date in the template,
      then increments until falling in the right month window. If this
      template gets used for, say, a few years, it will start to bog down the
      processing. If someone has a good quick fix I can add that.
      Unverified
      54f9b712
    • shall0pass's avatar
  13. May 11, 2023
  14. May 10, 2023
  15. May 09, 2023
    • TheTrueCaligari's avatar
      Fix for issue #319 (#1008) · 8faa7bd6
      TheTrueCaligari authored
      Unverified
      8faa7bd6
    • Alberto Gasparin's avatar
    • Jed Fox's avatar
      Enable 'curly' rule (#1015) · 54fa4bcc
      Jed Fox authored
      Multi-line `if`/`for` statements in JS can be confusing since there
      aren’t braces to indicate which code is enclosed in the statement. I set
      the configuration to `multi-line` to enforce usage of braces for
      multi-line statement bodies, but still allow things like `if (foo)
      return;`. I additionally added the `consistent` option to require braces
      for all elements of an if/else chain if one element has it. As you can
      see, this set of options pretty closely matches the existing code style.
      
      I was going to comment in #1008 about this stylistic change but realized
      that it’s (IMO) a little impolite to ask for code style changes unless
      they can be automatically enforced.
      
      Note that `if (foo) { \n return; \n }` is still valid and won’t be
      collapsed. I tried to automatically collapse all such cases but it was a
      lot of files and I didn’t want to pick out the useful from the useless
      differences.
      Unverified
      54fa4bcc
  16. May 08, 2023
  17. May 07, 2023
  18. May 06, 2023
  19. May 05, 2023
Loading