Skip to content
Snippets Groups Projects
  1. Jul 09, 2023
  2. Jul 05, 2023
  3. Jul 04, 2023
  4. Jul 03, 2023
  5. Jun 28, 2023
  6. Jun 26, 2023
    • Jed Fox's avatar
      Run ESLint at the top level once (#1202) · ed50e2b3
      Jed Fox authored
      This significantly speeds up `yarn lint` for me. It also ensures we’re
      listing all source files in the project, including the `.eslintrc` files
      and any other files that may be present.
      ed50e2b3
  7. Jun 23, 2023
  8. Jun 17, 2023
  9. Jun 15, 2023
  10. Jun 09, 2023
  11. Jun 04, 2023
  12. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      461132b9
  13. Apr 30, 2023
  14. Apr 06, 2023
  15. Mar 17, 2023
  16. Feb 28, 2023
  17. Feb 02, 2023
  18. Jan 14, 2023
  19. Jan 13, 2023
  20. Dec 30, 2022
  21. Dec 12, 2022
  22. Dec 04, 2022
  23. Nov 13, 2022
  24. Oct 25, 2022
  25. Aug 31, 2022
  26. Aug 23, 2022
  27. Jun 29, 2022
  28. Apr 29, 2022
Loading