Skip to content
Snippets Groups Projects
  1. Feb 08, 2024
  2. Feb 02, 2024
  3. Jan 19, 2024
  4. Jan 12, 2024
  5. Jan 09, 2024
  6. Jan 08, 2024
  7. Jan 06, 2024
  8. Dec 02, 2023
  9. Nov 22, 2023
  10. Nov 21, 2023
  11. Nov 20, 2023
  12. Nov 10, 2023
  13. Nov 04, 2023
  14. Oct 05, 2023
  15. Oct 04, 2023
  16. Sep 10, 2023
  17. Sep 03, 2023
  18. Aug 17, 2023
  19. Aug 09, 2023
  20. Aug 07, 2023
  21. Aug 02, 2023
  22. Jul 29, 2023
  23. Jul 18, 2023
  24. Jul 17, 2023
  25. Jul 09, 2023
  26. Jul 05, 2023
  27. Jul 04, 2023
  28. Jul 03, 2023
  29. Jun 28, 2023
  30. Jun 26, 2023
  31. Jun 23, 2023
  32. Jun 17, 2023
  33. Jun 15, 2023
  34. Jun 09, 2023
  35. Jun 04, 2023
  36. May 18, 2023
    • Shazib Hussain's avatar
      Fix electron app (#1003) · 461132b9
      Shazib Hussain authored
      
      Updates to the latest version of electron and moves the backend-frontend
      communication from node-ipc to websockets. This resolves the previous
      roadblock regarding `nodeIntegration` .
      
      Done
      
      - Remove node-ipc in favour of websockets. 
      - Move file copying out of `preload.js` to avoid importing module `fs`
      there
      - Bump all electron pacakge versions to the latest
      - Added new package for finding open ports as node-ipc is gone
      - Tweaked webpack config for above changes
      
      
      Partially fixes #468
      
      Questions/ Pending:
      - Literally every single test fails for me, presumably some issue with
      my setup/environment.
      - The websocket communication is not using TLS. I'm not sure how to
      enable this, or if we even need to as its all local.
      - Still need to create the CI for building/deploying but I'm not sure
      where start in this regard as i have no exp with it. Presumably we will
      need to point the electron auto-updater to the github releases url's. If
      people are happy with this PR I will look at adding the CI before its
      merged.
      - In dev mode only, I have disabled TLS security becuase my docker
      container's cert is not signed. I _assume_ this will be true for other
      people who spin up the server on thier own hardware. Perhaps I just need
      to change my cert to one from letsencrypt or something...
      
      Notes.
      I have not touched javascript in eons so my apologies if the commit
      trail is a bit fragmented. I tried to keep them fairly contained and
      then there is a slightly gnarly final commit fixing all the linter
      issues... Please let me know if you want me to squash some commits etc.
      
      I initially tried to move this to web workers the same way the web app
      does it but this was unsuccessful. I have found no way to spin up a
      worker in one place (frontend/backend) and then pass this worker to the
      other. The electron ipc channels don't allow you to directly pass
      objects such as workers, everything is cloned/serialised. Passing a port
      number so the other end can spin up its own socket works fine.
      
      ---------
      
      Co-authored-by: default avatarShazib Hussain <contact@shazib.com>
      Co-authored-by: default avatarJed Fox <git@jedfox.com>
      Unverified
      461132b9
  37. Apr 30, 2023
Loading