cleanup iterableTopologicalSort feature flag (#3262)

packages/desktop-client/src/components/settings/Experimental.tsx

@@ -89,9 +89,6 @@ export function ExperimentalFeatures() {
               Goal templates
             </FeatureToggle>
             <FeatureToggle flag="simpleFinSync">SimpleFIN sync</FeatureToggle>
-            <FeatureToggle flag="iterableTopologicalSort">
-              Iterable topological sort budget
-            </FeatureToggle>
           </View>
         ) : (
           <Link

packages/desktop-client/src/hooks/useFeatureFlag.ts

@@ -8,7 +8,6 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
   goalTemplatesEnabled: false,
   spendingReport: false,
   simpleFinSync: false,
-  iterableTopologicalSort: true,
 };
 
 export function useFeatureFlag(name: FeatureFlag): boolean {

packages/loot-core/src/server/spreadsheet/graph-data-structure.ts

-import { getPrefs } from '../prefs';
-
 // @ts-strict-ignore
 export function Graph() {
   const graph = {
@@ -81,42 +79,16 @@ export function Graph() {
   function topologicalSort(sourceNodes) {
     const visited = new Set();
     const sorted = [];
-    const prefs = getPrefs();
-    const iterableTopologicalSort =
-      prefs != null ? prefs['flags.iterableTopologicalSort'] : false;
 
     sourceNodes.forEach(name => {
       if (!visited.has(name)) {
-        if (iterableTopologicalSort) {
-          topologicalSortIterable(name, visited, sorted);
-        } else {
-          topologicalSortUntil(name, visited, sorted, 0);
-        }
+        topologicalSortIterable(name, visited, sorted);
       }
     });
 
     return sorted;
   }
 
-  function topologicalSortUntil(name, visited, sorted, level) {
-    visited.add(name);
-    if (level > 2500) {
-      console.error('Limit of recursions reached while sorting budget: 2500');
-      return;
-    }
-
-    const iter = adjacent(name).values();
-    let cur = iter.next();
-    while (!cur.done) {
-      if (!visited.has(cur.value)) {
-        topologicalSortUntil(cur.value, visited, sorted, level + 1);
-      }
-      cur = iter.next();
-    }
-
-    sorted.unshift(name);
-  }
-
   function topologicalSortIterable(name, visited, sorted) {
     const stackTrace: StackItem[] = [];
 

packages/loot-core/src/types/prefs.d.ts

@@ -6,8 +6,7 @@ export type FeatureFlag =
   | 'reportBudget'
   | 'goalTemplatesEnabled'
   | 'spendingReport'
-  | 'simpleFinSync'
-  | 'iterableTopologicalSort';
+  | 'simpleFinSync';
 
 /**
  * Cross-device preferences. These sync across devices when they are changed.

upcoming-release-notes/3262.md

+---
+category: Maintenance
+authors: [Matissjanis]
+---
+
+Cleanup `iterableTopologicalSort` feature flag.