remove pikaday monkeypatch (#1203)

AFAIK with the build-script upgrades we have done - this monkeypatch is
no longer necessary. The build size still seems to be the same.

packages/desktop-client/config-overrides.js

@@ -7,6 +7,7 @@ const {
   override,
   overrideDevServer,
 } = require('customize-cra');
+const { IgnorePlugin } = require('webpack');
 const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
 
 if (process.env.CI) {
@@ -35,6 +36,15 @@ module.exports = {
         generateStatsFile: true,
       }),
     ),
+    // Pikaday throws a warning if Moment.js is not installed however it doesn't
+    // actually require it to be installed. As we don't use Moment.js ourselves
+    // then we can just silence this warning.
+    addWebpackPlugin(
+      new IgnorePlugin({
+        contextRegExp: /moment$/,
+        resourceRegExp: /pikaday$/,
+      }),
+    ),
     config => {
       config.cache = false;
       return config;

patches/pikaday+1.8.0.patch

-diff --git a/node_modules/pikaday/pikaday.js b/node_modules/pikaday/pikaday.js
-index 8dae838..13ecfbe 100755
---- a/node_modules/pikaday/pikaday.js
-+++ b/node_modules/pikaday/pikaday.js
-@@ -12,8 +12,8 @@
-     if (typeof exports === 'object') {
-         // CommonJS module
-         // Load moment.js as an optional dependency
--        try { moment = require('moment'); } catch (e) {}
--        module.exports = factory(moment);
-+        // try { moment = require('moment'); } catch (e) {}
-+        module.exports = factory(null);
-     } else if (typeof define === 'function' && define.amd) {
-         // AMD. Register as an anonymous module.
-         define(function (req)

upcoming-release-notes/1203.md

+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Remove `pikaday` monkeypatch