add schedule name check to check templates (#2667)

* check schedule name

* note

packages/loot-core/src/server/budget/goaltemplates.ts

@@ -641,17 +641,33 @@ async function checkTemplates(): Promise<Notification> {
   const categories = await db.all(
     'SELECT * FROM v_categories WHERE tombstone = 0',
   );
+  let all_schedule_names = await db.all(
+    'SELECT name from schedules WHERE name NOT NULL AND tombstone = 0',
+  );
+  all_schedule_names = all_schedule_names.map(v => v.name);
 
   // run through each line and see if its an error
   for (let c = 0; c < categories.length; c++) {
     const category = categories[c];
     const template = category_templates[category.id];
+
     if (template) {
       for (let l = 0; l < template.length; l++) {
+        //check for basic error
         if (template[l].type === 'error') {
-          //return { type: 'message', message: "found a bad one",};
           errors.push(category.name + ': ' + template[l].line);
         }
+        // check schedule name error
+        if (template[l].type === 'schedule') {
+          if (!all_schedule_names.includes(template[l].name)) {
+            errors.push(
+              category.name +
+                ': Schedule “' +
+                template[l].name +
+                '” does not exist',
+            );
+          }
+        }
       }
     }
   }

upcoming-release-notes/2667.md

+---
+category: Enhancements
+authors: [youngcw]
+---
+
+Check schedule name when using the check templates function