Allow rendering a schedule in <Value /> (#706)

* Allow rendering a schedule rule in <Value />

* Refactor: RulesPage.getNthRule returns arrays for conditions/actions

* Visit the rules page after creating a schedule

packages/desktop-client/e2e/page-models/rules-page.js

@@ -26,8 +26,12 @@ export class RulesPage {
     const row = this.page.getByTestId('table').getByTestId('row').nth(index);
 
     return {
-      conditions: await row.getByTestId('conditions').textContent(),
-      actions: await row.getByTestId('actions').textContent(),
+      conditions: await row
+        .getByTestId('conditions')
+        .evaluate(el => [...el.children].map(c => c.textContent)),
+      actions: await row
+        .getByTestId('actions')
+        .evaluate(el => [...el.children].map(c => c.textContent)),
     };
   }
 

packages/desktop-client/e2e/rules.test.js

@@ -44,8 +44,8 @@ test.describe('Rules', () => {
     });
 
     expect(await rulesPage.getNthRule(0)).toMatchObject({
-      conditions: 'payee is Fast Internet',
-      actions: 'set category to General',
+      conditions: ['payee is Fast Internet'],
+      actions: ['set category to General'],
     });
 
     const accountPage = await navigation.goToAccountPage('Bank of America');

packages/desktop-client/e2e/schedules.test.js

@@ -54,6 +54,18 @@ test.describe('Schedules', () => {
       credit: '',
     });
 
+    // go to rules page
+    const rulesPage = await navigation.goToRulesPage();
+    expect(await rulesPage.getNthRule(0)).toMatchObject({
+      actions: ['link schedule Home Depot (2023-02-28)'],
+      conditions: [
+        'payee is Home Depot',
+        'account is HSBC',
+        'date is approx Every month on the 28th',
+        'amount is approx -25.00',
+      ],
+    });
+
     // Go back to schedules page
     await navigation.goToSchedulesPage();
     await schedulesPage.completeNthSchedule(0);

packages/desktop-client/src/components/ManageRules.js

@@ -117,6 +117,7 @@ export function Value({
         case 'payee':
         case 'category':
         case 'account':
+        case 'rule':
           if (valueIsRaw) {
             return value;
           }