Spending Report: card fix (#3135)

* spending card fix

* notes

packages/desktop-client/src/components/reports/graphs/SpendingGraph.tsx

@@ -140,7 +140,7 @@ export function SpendingGraph({
   const lastYear = monthUtils.prevYear(monthUtils.currentMonth());
   let selection;
   switch (mode) {
-    case 'Average':
+    case 'average':
       selection = 'average';
       break;
     case 'lastYear':

packages/desktop-client/src/components/reports/reports/Spending.tsx

@@ -321,8 +321,8 @@ export function Spending() {
                     )}
                     {showAverage && (
                       <ModeButton
-                        selected={mode === 'Average'}
-                        onSelect={() => setMode('Average')}
+                        selected={mode === 'average'}
+                        onSelect={() => setMode('average')}
                       >
                         Average
                       </ModeButton>

packages/desktop-client/src/components/reports/reports/SpendingCard.tsx

@@ -40,7 +40,7 @@ export function SpendingCard() {
       : monthUtils.getDay(monthUtils.currentDay()) - 1;
   const difference =
     data &&
-    data.intervalData[todayDay].lastMonth -
+    data.intervalData[todayDay][spendingReportTime] -
       data.intervalData[todayDay].thisMonth;
   const showLastMonth = data && Math.abs(data.intervalData[27].lastMonth) > 0;
 

packages/loot-core/src/types/models/reports.d.ts

@@ -32,6 +32,8 @@ export type balanceTypeOpType =
   | 'netAssets'
   | 'netDebts';
 
+export type spendingReportTimeType = 'lastMonth' | 'lastYear' | 'average';
+
 export type SpendingMonthEntity = Record<
   string | number,
   {

packages/loot-core/src/types/prefs.d.ts

 import { type numberFormats } from '../shared/util';
 
+import { spendingReportTimeType } from './models/reports';
+
 export type FeatureFlag =
   | 'reportBudget'
   | 'goalTemplatesEnabled'
@@ -51,7 +53,7 @@ export type LocalPrefs = Partial<
     reportsViewSummary: boolean;
     reportsViewLabel: boolean;
     spendingReportFilter: string;
-    spendingReportTime: string;
+    spendingReportTime: spendingReportTimeType;
     sidebarWidth: number;
     'mobile.showSpentColumn': boolean;
   } & Record<`flags.${FeatureFlag}`, boolean>

upcoming-release-notes/3135.md

+---
+category: Bugfix
+authors: [carkom]
+---
+
+Fixes spending card that doesn't show the correct difference number.