(electron) improved OS detection (#1658)

*  (electron) improved OS detection

* Release notes

package.json

@@ -19,7 +19,7 @@
   },
   "scripts": {
     "start": "yarn start:browser",
-    "start:desktop": "npm-run-all --parallel 'start:desktop-*'",
+    "start:desktop": "yarn rebuild-electron && npm-run-all --parallel 'start:desktop-*'",
     "start:desktop-node": "yarn workspace loot-core watch:node",
     "start:desktop-client": "yarn workspace @actual-app/web watch",
     "start:desktop-electron": "yarn workspace desktop-electron watch",

packages/loot-core/src/client/platform.electron.ts

-const isWindows =
-  navigator.platform && navigator.platform.toLowerCase() === 'win32';
+const os = require('os');
 
-const isMac =
-  navigator.platform && navigator.platform.toUpperCase().indexOf('MAC') >= 0;
+const isWindows = os.platform() === 'win32';
+const isMac = os.platform() === 'darwin';
+const isLinux = os.platform() === 'linux';
 
-export const isPlaywright = navigator.userAgent === 'playwright';
+export const isPlaywright = false;
 
 export const OS: 'windows' | 'mac' | 'linux' | 'unknown' = isWindows
   ? 'windows'
   : isMac
   ? 'mac'
-  : 'linux';
+  : isLinux
+  ? 'linux'
+  : 'unknown';
 export const env: 'web' | 'mobile' | 'unknown' = 'unknown';
 export const isBrowser = false;

upcoming-release-notes/1658.md

+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Electron: improving operating system detection