Skip to content
Snippets Groups Projects
Unverified Commit 422996f8 authored by DHRUV RAMDEV's avatar DHRUV RAMDEV Committed by GitHub
Browse files

fix: Margin when editing account on desktop (#2286)

* fix: Margin when editing account on desktop

* add release notes

* increase margin

* Update regression tests

* fix: Reduce padding in other areas

* update snapshots
parent 9cad57c6
No related branches found
No related tags found
No related merge requests found
Showing
with 9 additions and 3 deletions
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
File suppressed by a .gitattributes entry or the file's encoding is unsupported.
...@@ -148,6 +148,8 @@ export function Balances({ ...@@ -148,6 +148,8 @@ export function Balances({
opacity: selectedItems.size > 0 || showExtraBalances ? 1 : 0, opacity: selectedItems.size > 0 || showExtraBalances ? 1 : 0,
}, },
'&:hover svg': { opacity: 1 }, '&:hover svg': { opacity: 1 },
paddingTop: 1,
paddingBottom: 1,
}} }}
> >
<CellValue <CellValue
......
...@@ -118,7 +118,9 @@ export function AccountHeader({ ...@@ -118,7 +118,9 @@ export function AccountHeader({
/> />
<View style={{ ...styles.pageContent, paddingBottom: 10, flexShrink: 0 }}> <View style={{ ...styles.pageContent, paddingBottom: 10, flexShrink: 0 }}>
<View style={{ marginTop: 2, alignItems: 'flex-start' }}> <View
style={{ marginTop: 2, marginBottom: 10, alignItems: 'flex-start' }}
>
<View> <View>
{editingName ? ( {editingName ? (
<InitialFocus> <InitialFocus>
...@@ -133,6 +135,8 @@ export function AccountHeader({ ...@@ -133,6 +135,8 @@ export function AccountHeader({
marginTop: -5, marginTop: -5,
marginBottom: -2, marginBottom: -2,
marginLeft: -5, marginLeft: -5,
paddingTop: 2,
paddingBottom: 2,
}} }}
/> />
</InitialFocus> </InitialFocus>
...@@ -156,7 +160,7 @@ export function AccountHeader({ ...@@ -156,7 +160,7 @@ export function AccountHeader({
fontSize: 25, fontSize: 25,
fontWeight: 500, fontWeight: 500,
marginRight: 5, marginRight: 5,
marginBottom: 5, marginBottom: -1,
}} }}
data-testid="account-name" data-testid="account-name"
> >
...@@ -188,7 +192,7 @@ export function AccountHeader({ ...@@ -188,7 +192,7 @@ export function AccountHeader({
</View> </View>
) : ( ) : (
<View <View
style={{ fontSize: 25, fontWeight: 500, marginBottom: 5 }} style={{ fontSize: 25, fontWeight: 500, marginBottom: -1 }}
data-testid="account-name" data-testid="account-name"
> >
{account && account.closed {account && account.closed
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment