Fix transfer category in temporary transactions (#3239)

* Fix transfer category in temporary transactions

* Add visual regression tests to prevent this issue in the future

* Add release notes

packages/desktop-client/e2e/page-models/account-page.js

@@ -31,17 +31,29 @@ export class AccountPage {
   }
 
   /**
-   * Create a single transaction
+   * Enter details of a transaction
    */
-  async createSingleTransaction(transaction) {
+  async enterSingleTransaction(transaction) {
     await this.addNewTransactionButton.click();
-
     await this._fillTransactionFields(this.newTransactionRow, transaction);
+  }
 
+  /**
+   * Finish adding a transaction
+   */
+  async addEnteredTransaction() {
     await this.addTransactionButton.click();
     await this.cancelTransactionButton.click();
   }
 
+  /**
+   * Create a single transaction
+   */
+  async createSingleTransaction(transaction) {
+    await this.enterSingleTransaction(transaction);
+    await this.addEnteredTransaction();
+  }
+
   /**
    * Create split transactions
    */
@@ -82,6 +94,15 @@ export class AccountPage {
    */
   getNthTransaction(index) {
     const row = this.transactionTableRow.nth(index);
+
+    return this._getTransactionDetails(row);
+  }
+
+  getEnteredTransaction() {
+    return this._getTransactionDetails(this.newTransactionRow);
+  }
+
+  _getTransactionDetails(row) {
     const account = row.getByTestId('account');
 
     return {

packages/desktop-client/e2e/transactions.test.js

@@ -141,4 +141,26 @@ test.describe('Transactions', () => {
     await expect(thirdTransaction.credit).toHaveText('');
     await expect(page).toMatchThemeScreenshots();
   });
+
+  test('creates a transfer test transaction', async () => {
+    await accountPage.enterSingleTransaction({
+      payee: 'Bank of America',
+      notes: 'Notes field',
+      debit: '12.34',
+    });
+
+    let transaction = accountPage.getEnteredTransaction();
+    await expect(transaction.category.locator('input')).toHaveValue('Transfer');
+    await expect(page).toMatchThemeScreenshots();
+
+    await accountPage.addEnteredTransaction();
+
+    transaction = accountPage.getNthTransaction(0);
+    await expect(transaction.payee).toHaveText('Bank of America');
+    await expect(transaction.notes).toHaveText('Notes field');
+    await expect(transaction.category).toHaveText('Transfer');
+    await expect(transaction.debit).toHaveText('12.34');
+    await expect(transaction.credit).toHaveText('');
+    await expect(page).toMatchThemeScreenshots();
+  });
 });

packages/desktop-client/src/components/transactions/TransactionsTable.jsx

@@ -995,7 +995,9 @@ const Transaction = memo(function Transaction({
   const account = accounts && accountId && getAccountsById(accounts)[accountId];
 
   const isChild = transaction.is_child;
-  const transferAcct = transferAccountsByTransaction[id];
+  const transferAcct = isTemporaryId(id)
+    ? getAccountsById(accounts)[payee?.transfer_acct]
+    : transferAccountsByTransaction[id];
   const isBudgetTransfer = transferAcct && transferAcct.offbudget === 0;
   const isOffBudget = account && account.offbudget === 1;
 
@@ -1353,7 +1355,7 @@ const Transaction = memo(function Transaction({
             </View>
           </CellButton>
         </Cell>
-      ) : isBudgetTransfer || isOffBudget || isPreview ? (
+      ) : isBudgetTransfer || isOffBudget ? (
         <InputCell
           /* Category field for transfer and off-budget transactions
      (NOT preview, it is covered first) */
@@ -1361,7 +1363,7 @@ const Transaction = memo(function Transaction({
           width="flex"
           exposed={focusedField === 'category'}
           focused={focusedField === 'category'}
-          onExpose={name => !isPreview && onEdit(id, name)}
+          onExpose={name => onEdit(id, name)}
           value={
             isParent
               ? 'Split'

upcoming-release-notes/3239.md

+---
+category: Bugfix
+authors: [jfdoming]
+---
+
+Fix transfer category in temporary transactions