Fix some additional incorrect types (#2676)

* Fix some additional incorrect types

- This is part of working towards having enough correct types to be able to run tsc on our packed api without error.
- Working towards being able to ship types for the api in the package

* Add release note

packages/desktop-client/src/components/ThemeSelector.tsx

@@ -26,6 +26,7 @@ export function ThemeSelector({ style }: ThemeSelectorProps) {
     dark: SvgMoonStars,
     auto: SvgSystem,
     midnight: SvgMoonStars,
+    development: SvgMoonStars,
   } as const;
 
   function onMenuSelect(newTheme: Theme) {

packages/desktop-client/src/style/theme.tsx

@@ -33,7 +33,11 @@ export function useTheme() {
 export function ThemeStyle() {
   const [theme] = useTheme();
   const [themeColors, setThemeColors] = useState<
-    typeof lightTheme | typeof darkTheme | typeof midnightTheme | undefined
+    | typeof lightTheme
+    | typeof darkTheme
+    | typeof midnightTheme
+    | typeof developmentTheme
+    | undefined
   >(undefined);
 
   useEffect(() => {

packages/loot-core/src/types/models/index.d.ts

@@ -2,6 +2,7 @@ export type * from './account';
 export type * from './category';
 export type * from './category-group';
 export type * from './gocardless';
+export type * from './simplefin';
 export type * from './note';
 export type * from './payee';
 export type * from './reports';

packages/loot-core/src/types/models/transaction.d.ts

@@ -26,7 +26,11 @@ export interface NewTransactionEntity {
   subtransactions?: Omit<NewTransactionEntity, 'account' | 'date'>[];
 }
 
-export interface TransactionEntity extends NewTransactionEntity {
+export interface TransactionEntity
+  extends Omit<
+    NewTransactionEntity,
+    'account' | 'category' | 'payee' | 'schedule' | 'subtransactions'
+  > {
   id: string;
   account: AccountEntity;
   category?: CategoryEntity;

packages/loot-core/src/types/prefs.d.ts

@@ -58,10 +58,12 @@ export type LocalPrefs = Partial<
   } & Record<`flags.${FeatureFlag}`, boolean>
 >;
 
-export type Theme = 'light' | 'dark' | 'auto' | 'midnight';
+export type Theme = 'light' | 'dark' | 'auto' | 'midnight' | 'development';
 export type GlobalPrefs = Partial<{
   floatingSidebar: boolean;
   maxMonths: number;
+  autoUpdate: boolean;
+  keyId?: string;
   theme: Theme;
   documentDir: string; // Electron only
 }>;

packages/loot-core/src/types/server-handlers.d.ts

-import { GlobalPrefs, LocalPrefs } from '../client/state-types/prefs';
 import { ParseFileResult } from '../server/accounts/parse-file';
 import { batchUpdateTransactions } from '../server/accounts/transactions';
 import { Backup } from '../server/backups';
@@ -17,6 +16,7 @@ import {
   SimpleFinAccount,
   PayeeEntity,
 } from './models';
+import { GlobalPrefs, LocalPrefs } from './prefs';
 import { EmptyObject } from './util';
 
 export interface ServerHandlers {

upcoming-release-notes/2676.md

+---
+category: Maintenance
+authors: [twk3]
+---
+
+Fix some type errors found by the API packaging