Improve api output types (#2567)

* Improve api output types

- Fixes some missing models
- Fixes some output path aliasing

* Add changelog

packages/api/tsconfig.dist.json

@@ -10,6 +10,7 @@
     "outDir": "dist",
     "declarationDir": "@types",
     "paths": {
+      "loot-core/src/*": ["./loot-core/*"],
       "loot-core/*": ["./@types/loot-core/*"],
     }
   },

packages/loot-core/src/server/importers/ynab5.ts

@@ -8,6 +8,7 @@ import { v4 as uuidv4 } from 'uuid';
 
 import * as monthUtils from '../../shared/months';
 import { sortByKey, groupBy } from '../../shared/util';
+import { CategoryGroupEntity } from '../../types/models';
 
 import { YNAB5 } from './ynab5-types';
 
@@ -338,10 +339,16 @@ function equalsIgnoreCase(stringa: string, stringb: string): boolean {
   );
 }
 
-function findByNameIgnoreCase(categories: YNAB5.CategoryGroup[], name: string) {
+function findByNameIgnoreCase(
+  categories: (YNAB5.CategoryGroup | CategoryGroupEntity)[],
+  name: string,
+) {
   return categories.find(cat => equalsIgnoreCase(cat.name, name));
 }
 
-function findIdByName(categories: YNAB5.CategoryGroup[], name: string) {
+function findIdByName(
+  categories: (YNAB5.CategoryGroup | CategoryGroupEntity)[],
+  name: string,
+) {
   return findByNameIgnoreCase(categories, name)?.id;
 }

packages/loot-core/src/types/api-handlers.d.ts

 import { type batchUpdateTransactions } from '../server/accounts/transactions';
 
+import type {
+  TransactionEntity,
+  AccountEntity,
+  CategoryGroupEntity,
+  CategoryEntity,
+  PayeeEntity,
+} from './models';
 import { type ServerHandlers } from './server-handlers';
 
 export interface ApiHandlers {
@@ -107,7 +114,7 @@ export interface ApiHandlers {
 
   'api/categories-get': (arg: {
     grouped;
-  }) => Promise<Array<CategoryGroupEntity> | Array<CategoryEntity>>;
+  }) => Promise<Array<CategoryGroupEntity | CategoryEntity>>;
 
   'api/category-groups-get': () => Promise<CategoryGroupEntity[]>;
 

upcoming-release-notes/2567.md

+---
+category: Maintenance
+authors: [twk3]
+---
+
+Improve API output types.