Unflag custom reports (#2554)

* remove featureflag

* notes

* merge fixes

* vrt

---------

Co-authored-by: youngcw <calebyoung94@gmail.com>

packages/desktop-client/src/components/reports/Overview.tsx

@@ -25,7 +25,6 @@ export function Overview() {
   const location = useLocation();
   sessionStorage.setItem('url', location.pathname);
 
-  const customReportsFeatureFlag = useFeatureFlag('customReports');
   const spendingReportFeatureFlag = useFeatureFlag('spendingReport');
 
   const accounts = useAccounts();
@@ -43,7 +42,7 @@ export function Overview() {
             }}
           >
             <PageHeader title="Reports" />
-            {customReportsFeatureFlag && !isNarrowWidth && (
+            {!isNarrowWidth && (
               <Link to="/reports/custom" style={{ textDecoration: 'none' }}>
                 <Button type="primary">
                   <Text>Create new custom report</Text>
@@ -66,9 +65,7 @@ export function Overview() {
         <CashFlowCard />
         {spendingReportFeatureFlag && <SpendingCard />}
       </View>
-      {customReportsFeatureFlag && (
-        <CustomReportListCards reports={customReports} />
-      )}
+      <CustomReportListCards reports={customReports} />
     </Page>
   );
 }

packages/desktop-client/src/components/settings/Experimental.tsx

@@ -79,7 +79,6 @@ export function ExperimentalFeatures() {
       primaryAction={
         expanded ? (
           <View style={{ gap: '1em' }}>
-            <FeatureToggle flag="customReports">Custom reports</FeatureToggle>
             <FeatureToggle flag="spendingReport">
               Monthly spending
             </FeatureToggle>

packages/desktop-client/src/hooks/useFeatureFlag.ts

@@ -6,7 +6,6 @@ import type { FeatureFlag } from 'loot-core/src/types/prefs';
 const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
   reportBudget: false,
   goalTemplatesEnabled: false,
-  customReports: false,
   spendingReport: false,
   simpleFinSync: false,
   iterableTopologicalSort: true,

packages/loot-core/src/types/prefs.d.ts

@@ -3,7 +3,6 @@ import { type numberFormats } from '../shared/util';
 export type FeatureFlag =
   | 'reportBudget'
   | 'goalTemplatesEnabled'
-  | 'customReports'
   | 'spendingReport'
   | 'simpleFinSync'
   | 'iterableTopologicalSort';

upcoming-release-notes/2554.md

+---
+category: Features
+authors: [carkom]
+---
+
+Removing custom reports from feature flag "experimental" state.