Skip to content
Snippets Groups Projects
  1. Jun 24, 2023
  2. Jun 09, 2023
  3. May 29, 2023
    • Jed Fox's avatar
      More import-related ESLint rules (#1070) · e660e1e7
      Jed Fox authored
      - Enforce that imports from the same package are merged into a single
      import
      - In `loot-core`, require that imports of other `loot-core` files use a
      relative import (like the vast majority of such imports) rather than
      specifiers starting with `loot-core/` (probably a result of moving files
      out of other packages into `loot-core`)
      Unverified
      e660e1e7
  4. May 28, 2023
  5. May 09, 2023
    • Alberto Gasparin's avatar
    • Jed Fox's avatar
      Enable 'curly' rule (#1015) · 54fa4bcc
      Jed Fox authored
      Multi-line `if`/`for` statements in JS can be confusing since there
      aren’t braces to indicate which code is enclosed in the statement. I set
      the configuration to `multi-line` to enforce usage of braces for
      multi-line statement bodies, but still allow things like `if (foo)
      return;`. I additionally added the `consistent` option to require braces
      for all elements of an if/else chain if one element has it. As you can
      see, this set of options pretty closely matches the existing code style.
      
      I was going to comment in #1008 about this stylistic change but realized
      that it’s (IMO) a little impolite to ask for code style changes unless
      they can be automatically enforced.
      
      Note that `if (foo) { \n return; \n }` is still valid and won’t be
      collapsed. I tried to automatically collapse all such cases but it was a
      lot of files and I didn’t want to pick out the useful from the useless
      differences.
      Unverified
      54fa4bcc
  6. Apr 30, 2023
  7. Apr 21, 2023
  8. Apr 12, 2023
  9. Apr 03, 2023
    • Alberto Gasparin's avatar
      Convert loot-core to TS p1 (#841) · 79ad04dd
      Alberto Gasparin authored
      Part 1 of the conversion. Mostly renaming js to ts and making sure
      things make still sense. Added also handy TS ESLint rules.
      
      In order to support the various .web/.electron/... I ended up adopting
      `index.d.ts` as pattern to share type definition. Let me know if that
      makes sense for you too. Right now the function type definition is
      duplicated, but the solution will be importing from `index.d.ts` and
      using `const fn: FnDef = () => ...` that way we can keep all variants in
      sync from a single type file.
      
      Such rewrite however is better done in another PR otherwise we risk
      confusing git and loosing history (rename + too many changes). Another
      thing that might do in the next PR is convert all files to ESModules, as
      things get confusing between CJS exports, ESM default/named and TS adds
      extra complains.
      Unverified
      79ad04dd
  10. Mar 21, 2023
  11. Mar 05, 2023
  12. Mar 02, 2023
  13. Feb 28, 2023
  14. Jan 25, 2023
  15. Jan 18, 2023
  16. Jan 02, 2023
  17. Dec 30, 2022
  18. Sep 02, 2022
  19. Aug 25, 2022
  20. Jul 24, 2022
Loading