From f5fde3495292d4e0e92f1e1b2ccda3a5871a83fb Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Sat, 20 Apr 2024 22:36:22 +0100
Subject: [PATCH] :bug: fix budget-type identification when deleting files
 (#2649)

---
 packages/loot-core/src/server/main.ts | 7 ++++---
 upcoming-release-notes/2649.md        | 6 ++++++
 2 files changed, 10 insertions(+), 3 deletions(-)
 create mode 100644 upcoming-release-notes/2649.md

diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.ts
index aa13465ac..0cd0ac6c9 100644
--- a/packages/loot-core/src/server/main.ts
+++ b/packages/loot-core/src/server/main.ts
@@ -15,6 +15,7 @@ import { isNonProductionEnvironment } from '../shared/environment';
 import * as monthUtils from '../shared/months';
 import { q, Query } from '../shared/query';
 import { amountToInteger, stringToInteger } from '../shared/util';
+import { type Budget } from '../types/budget';
 import { Handlers } from '../types/handlers';
 
 import { exportToCSV, exportQueryToCSV } from './accounts/export-to-csv';
@@ -1576,10 +1577,10 @@ handlers['get-budgets'] = async function () {
           if (name !== DEMO_BUDGET_ID) {
             return {
               id: name,
-              cloudFileId: prefs.cloudFileId,
-              groupId: prefs.groupId,
+              ...(prefs.cloudFileId ? { cloudFileId: prefs.cloudFileId } : {}),
+              ...(prefs.groupId ? { groupId: prefs.groupId } : {}),
               name: prefs.budgetName || '(no name)',
-            };
+            } satisfies Budget;
           }
         }
 
diff --git a/upcoming-release-notes/2649.md b/upcoming-release-notes/2649.md
new file mode 100644
index 000000000..f7e3fdbc5
--- /dev/null
+++ b/upcoming-release-notes/2649.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Do not show "delete remote file" option for local budget files.
-- 
GitLab