From ea675f11ee69bf7a2de83b1858fd99a81e157b8d Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Wed, 18 Sep 2024 08:03:53 +0100
Subject: [PATCH] :bug: (synced-prefs) fix bulk-reading not working in import
modal (#3460)
---
packages/desktop-client/src/hooks/useSyncedPrefs.ts | 2 +-
packages/loot-core/src/client/query-hooks.tsx | 2 +-
upcoming-release-notes/3460.md | 6 ++++++
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 upcoming-release-notes/3460.md
diff --git a/packages/desktop-client/src/hooks/useSyncedPrefs.ts b/packages/desktop-client/src/hooks/useSyncedPrefs.ts
index 604785202..ca8788ecb 100644
--- a/packages/desktop-client/src/hooks/useSyncedPrefs.ts
+++ b/packages/desktop-client/src/hooks/useSyncedPrefs.ts
@@ -16,7 +16,7 @@ export function useSyncedPrefs(): [SyncedPrefs, SetSyncedPrefsAction] {
const prefs = useMemo<SyncedPrefs>(
() =>
- queryData.reduce(
+ (queryData ?? []).reduce(
(carry, { id, value }) => ({
...carry,
[id]: value,
diff --git a/packages/loot-core/src/client/query-hooks.tsx b/packages/loot-core/src/client/query-hooks.tsx
index 930acfc58..8e4f5810a 100644
--- a/packages/loot-core/src/client/query-hooks.tsx
+++ b/packages/loot-core/src/client/query-hooks.tsx
@@ -82,7 +82,7 @@ export function useQuery<Response = unknown>(
makeQuery: () => Query,
deps: DependencyList,
): {
- data: Response;
+ data: null | Response;
overrideData: (newData: Response) => void;
isLoading: boolean;
} {
diff --git a/upcoming-release-notes/3460.md b/upcoming-release-notes/3460.md
new file mode 100644
index 000000000..b39dfcb9c
--- /dev/null
+++ b/upcoming-release-notes/3460.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatisJanis]
+---
+
+SyncedPrefs: fix import prefs not reading correctly.
--
GitLab