From dff9911a1562731c1536c2524a16a3b691e1dcb3 Mon Sep 17 00:00:00 2001 From: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Date: Sun, 28 Jul 2024 21:47:13 +0100 Subject: [PATCH] [Fix] "Enter" key should save on "Cover Overspending" popup (#3153) * allow autocomplete events to fire when dropdown is closed * release notes * simpler solution * release notes --- .../src/components/budget/rollover/CoverMenu.tsx | 6 +----- upcoming-release-notes/3153.md | 6 ++++++ 2 files changed, 7 insertions(+), 5 deletions(-) create mode 100644 upcoming-release-notes/3153.md diff --git a/packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx b/packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx index 553e28d4e..68c5d0c7f 100644 --- a/packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx +++ b/packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx @@ -44,11 +44,7 @@ export function CoverMenu({ onSelect={(id: string | undefined) => setCategoryId(id || null)} inputProps={{ inputRef: node, - onKeyDown: e => { - if (e.key === 'Enter') { - submit(); - } - }, + onEnter: event => !event.defaultPrevented && submit(), placeholder: '(none)', }} showHiddenCategories={false} diff --git a/upcoming-release-notes/3153.md b/upcoming-release-notes/3153.md new file mode 100644 index 000000000..2a8861e2c --- /dev/null +++ b/upcoming-release-notes/3153.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MikesGlitch] +--- + +Fix the "Enter" shortcut not saving on "Cover Overspending" popup -- GitLab