From db65e837220ed837456da306d44d57744b1a2c19 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Sat, 29 Apr 2023 17:26:34 +0100
Subject: [PATCH] :bug: (Text) single-line text (#967)
---
packages/desktop-client/src/components/common.js | 15 +++++++++++++--
.../src/components/spreadsheet/CellValue.js | 1 -
upcoming-release-notes/967.md | 6 ++++++
3 files changed, 19 insertions(+), 3 deletions(-)
create mode 100644 upcoming-release-notes/967.md
diff --git a/packages/desktop-client/src/components/common.js b/packages/desktop-client/src/components/common.js
index bcb4346ac..899df7033 100644
--- a/packages/desktop-client/src/components/common.js
+++ b/packages/desktop-client/src/components/common.js
@@ -37,9 +37,20 @@ export { default as View } from './common/View';
export { default as Text } from './common/Text';
export { default as Stack } from './Stack';
-export function TextOneLine({ children, centered, ...props }) {
+export function TextOneLine({ children, ...props }) {
return (
- <Text numberOfLines={1} {...props}>
+ <Text
+ {...props}
+ style={[
+ props.style,
+ {
+ overflow: 'hidden',
+ textOverflow: 'ellipsis',
+ whiteSpace: 'nowrap',
+ display: 'block',
+ },
+ ]}
+ >
{children}
</Text>
);
diff --git a/packages/desktop-client/src/components/spreadsheet/CellValue.js b/packages/desktop-client/src/components/spreadsheet/CellValue.js
index 0ae919dd5..cefcbf882 100644
--- a/packages/desktop-client/src/components/spreadsheet/CellValue.js
+++ b/packages/desktop-client/src/components/spreadsheet/CellValue.js
@@ -17,7 +17,6 @@ function CellValue({ binding, type, formatter, style, getStyle, debug }) {
style,
getStyle && getStyle(value),
]}
- numberOfLines={1}
data-testid={name}
data-cellname={name}
>
diff --git a/upcoming-release-notes/967.md b/upcoming-release-notes/967.md
new file mode 100644
index 000000000..c18af5f2a
--- /dev/null
+++ b/upcoming-release-notes/967.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Re-introduce single line text blocks (useful for mobile)
--
GitLab