From d89a016ab1e0093a5ea6fee46a08a23932dfb040 Mon Sep 17 00:00:00 2001
From: Robert Dyer <rdyer@unl.edu>
Date: Fri, 12 Apr 2024 09:40:01 -0500
Subject: [PATCH] Do not allow hiding income category group (#2581)
* Do not allow hiding income category group
* add release note
* rename file
* Migrate DB so income groups are not hidden
* Update migration to explicitly match on is_income = 1
---
.../desktop-client/src/components/budget/SidebarGroup.tsx | 2 +-
.../migrations/1712784523000_unhide_input_group.sql | 8 ++++++++
upcoming-release-notes/2581.md | 6 ++++++
3 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 packages/loot-core/migrations/1712784523000_unhide_input_group.sql
create mode 100644 upcoming-release-notes/2581.md
diff --git a/packages/desktop-client/src/components/budget/SidebarGroup.tsx b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
index bbdd36b36..c76254057 100644
--- a/packages/desktop-client/src/components/budget/SidebarGroup.tsx
+++ b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
@@ -125,7 +125,7 @@ export function SidebarGroup({
}}
items={[
{ name: 'add-category', text: 'Add category' },
- {
+ !group.is_income && {
name: 'toggle-visibility',
text: group.hidden ? 'Show' : 'Hide',
},
diff --git a/packages/loot-core/migrations/1712784523000_unhide_input_group.sql b/packages/loot-core/migrations/1712784523000_unhide_input_group.sql
new file mode 100644
index 000000000..0f432d036
--- /dev/null
+++ b/packages/loot-core/migrations/1712784523000_unhide_input_group.sql
@@ -0,0 +1,8 @@
+BEGIN TRANSACTION;
+
+UPDATE category_groups
+SET
+ hidden = 0
+WHERE is_income = 1;
+
+COMMIT;
\ No newline at end of file
diff --git a/upcoming-release-notes/2581.md b/upcoming-release-notes/2581.md
new file mode 100644
index 000000000..9a591a771
--- /dev/null
+++ b/upcoming-release-notes/2581.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [psybers]
+---
+
+Do not allow hiding the income category group.
--
GitLab