From d6afc85a8c179d0e4c6ac3249097a4d1989f9c60 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Sun, 18 Aug 2024 11:17:42 +0100
Subject: [PATCH] :sparkles: adding feedback links besides the feature flags
(#3283)
---
.../src/components/settings/Experimental.tsx | 54 ++++++++++++++-----
upcoming-release-notes/3283.md | 6 +++
2 files changed, 46 insertions(+), 14 deletions(-)
create mode 100644 upcoming-release-notes/3283.md
diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsx
index 0fb7cadaa..8165e465f 100644
--- a/packages/desktop-client/src/components/settings/Experimental.tsx
+++ b/packages/desktop-client/src/components/settings/Experimental.tsx
@@ -1,4 +1,5 @@
import { type ReactNode, useState } from 'react';
+import { Trans, useTranslation } from 'react-i18next';
import type { FeatureFlag } from 'loot-core/src/types/prefs';
@@ -17,11 +18,13 @@ type FeatureToggleProps = {
disableToggle?: boolean;
error?: ReactNode;
children: ReactNode;
+ feedbackLink?: string;
};
function FeatureToggle({
flag: flagName,
disableToggle = false,
+ feedbackLink,
error,
children,
}: FeatureToggleProps) {
@@ -40,7 +43,15 @@ function FeatureToggle({
<View
style={{ color: disableToggle ? theme.pageTextSubdued : 'inherit' }}
>
- {children}
+ <View style={{ flexDirection: 'row', alignItems: 'center', gap: 5 }}>
+ {children}
+ {feedbackLink && (
+ <Link variant="external" to={feedbackLink}>
+ <Trans>(give feedback)</Trans>
+ </Link>
+ )}
+ </View>
+
{disableToggle && (
<Text
style={{
@@ -57,6 +68,7 @@ function FeatureToggle({
}
function ReportBudgetFeature() {
+ const { t } = useTranslation();
const [budgetType = 'rollover'] = useSyncedPref('budgetType');
const enabled = useFeatureFlag('reportBudget');
const blockToggleOff = budgetType === 'report' && enabled;
@@ -64,9 +76,10 @@ function ReportBudgetFeature() {
<FeatureToggle
flag="reportBudget"
disableToggle={blockToggleOff}
- error="Switch to a rollover budget before turning off this feature"
+ error={t('Switch to a rollover budget before turning off this feature')}
+ feedbackLink="https://github.com/actualbudget/actual/issues/2999"
>
- Budget mode toggle
+ <Trans>Budget mode toggle</Trans>
</FeatureToggle>
);
}
@@ -79,18 +92,29 @@ export function ExperimentalFeatures() {
primaryAction={
expanded ? (
<View style={{ gap: '1em' }}>
- <FeatureToggle flag="spendingReport">
- Monthly spending report
+ <FeatureToggle
+ flag="spendingReport"
+ feedbackLink="https://github.com/actualbudget/actual/issues/2820"
+ >
+ <Trans>Monthly spending report</Trans>
</FeatureToggle>
<ReportBudgetFeature />
<FeatureToggle flag="goalTemplatesEnabled">
- Goal templates
+ <Trans>Goal templates</Trans>
+ </FeatureToggle>
+ <FeatureToggle
+ flag="simpleFinSync"
+ feedbackLink="https://github.com/actualbudget/actual/issues/2272"
+ >
+ <Trans>SimpleFIN sync</Trans>
</FeatureToggle>
- <FeatureToggle flag="simpleFinSync">SimpleFIN sync</FeatureToggle>
- <FeatureToggle flag="dashboards">
- Customizable reports page (dashboards)
+ <FeatureToggle
+ flag="dashboards"
+ feedbackLink="https://github.com/actualbudget/actual/issues/3282"
+ >
+ <Trans>Customizable reports page (dashboards)</Trans>
</FeatureToggle>
</View>
) : (
@@ -104,16 +128,18 @@ export function ExperimentalFeatures() {
color: theme.pageTextPositive,
}}
>
- I understand the risks, show experimental features
+ <Trans>I understand the risks, show experimental features</Trans>
</Link>
)
}
>
<Text>
- <strong>Experimental features.</strong> These features are not fully
- tested and may not work as expected. THEY MAY CAUSE IRRECOVERABLE DATA
- LOSS. They may do nothing at all. Only enable them if you know what you
- are doing.
+ <Trans>
+ <strong>Experimental features.</strong> These features are not fully
+ tested and may not work as expected. THEY MAY CAUSE IRRECOVERABLE DATA
+ LOSS. They may do nothing at all. Only enable them if you know what
+ you are doing.
+ </Trans>
</Text>
</Setting>
);
diff --git a/upcoming-release-notes/3283.md b/upcoming-release-notes/3283.md
new file mode 100644
index 000000000..c140ab9d2
--- /dev/null
+++ b/upcoming-release-notes/3283.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [MatissJanis]
+---
+
+Added feedback links besides the experimental feature flags.
--
GitLab