From cd54a2093edd7517731b88eb327de533ca9a4d16 Mon Sep 17 00:00:00 2001
From: Sean Tsai <aleetsaiya@gmail.com>
Date: Sat, 5 Aug 2023 19:40:48 +0800
Subject: [PATCH] Fix the mobile footer color (#1456)
fix #1445
---
packages/desktop-client/src/components/FinancesApp.tsx | 6 ++----
packages/desktop-client/src/style/themes/dark.ts | 3 +++
packages/desktop-client/src/style/themes/light.ts | 3 +++
upcoming-release-notes/1456.md | 5 +++++
4 files changed, 13 insertions(+), 4 deletions(-)
create mode 100644 upcoming-release-notes/1456.md
diff --git a/packages/desktop-client/src/components/FinancesApp.tsx b/packages/desktop-client/src/components/FinancesApp.tsx
index 21523e9db..534db6336 100644
--- a/packages/desktop-client/src/components/FinancesApp.tsx
+++ b/packages/desktop-client/src/components/FinancesApp.tsx
@@ -163,9 +163,7 @@ function NavTab({ icon: TabIcon, name, path }) {
to={path}
style={({ isActive }) => ({
alignItems: 'center',
- color: isActive
- ? theme.sidebarItemAccentSelected
- : theme.sidebarItemText,
+ color: isActive ? theme.mobileNavItemSelected : theme.mobileNavItem,
display: 'flex',
flexDirection: 'column',
textDecoration: 'none',
@@ -182,7 +180,7 @@ function MobileNavTabs() {
return (
<div
style={{
- backgroundColor: theme.sidebarBackground,
+ backgroundColor: theme.mobileNavBackground,
borderTop: `1px solid ${theme.menuBorder}`,
bottom: 0,
...styles.shadow,
diff --git a/packages/desktop-client/src/style/themes/dark.ts b/packages/desktop-client/src/style/themes/dark.ts
index 9a27a6690..9f26952e5 100644
--- a/packages/desktop-client/src/style/themes/dark.ts
+++ b/packages/desktop-client/src/style/themes/dark.ts
@@ -64,6 +64,9 @@ export const altMenuItemTextSelected = colorPalette.purple400;
export const altMenuItemTextHeader = colorPalette.purple500;
export const altMenuBorder = colorPalette.navy200;
export const altMenuBorderHover = colorPalette.purple400;
+export const mobileNavBackground = colorPalette.navy800;
+export const mobileNavItem = colorPalette.navy150;
+export const mobileNavItemSelected = colorPalette.purple400;
// Button
export const buttonMenuText = colorPalette.navy100;
diff --git a/packages/desktop-client/src/style/themes/light.ts b/packages/desktop-client/src/style/themes/light.ts
index b800f2956..9752e6591 100644
--- a/packages/desktop-client/src/style/themes/light.ts
+++ b/packages/desktop-client/src/style/themes/light.ts
@@ -64,6 +64,9 @@ export const altMenuItemTextSelected = colorPalette.purple300;
export const altMenuItemTextHeader = colorPalette.purple300;
export const altMenuBorder = colorPalette.blue700;
export const altMenuBorderHover = colorPalette.purple300;
+export const mobileNavBackground = colorPalette.white;
+export const mobileNavItem = 'rgb(142, 142, 143)';
+export const mobileNavItemSelected = colorPalette.purple500;
// Button
export const buttonMenuText = colorPalette.navy100;
diff --git a/upcoming-release-notes/1456.md b/upcoming-release-notes/1456.md
new file mode 100644
index 000000000..3195cb6f0
--- /dev/null
+++ b/upcoming-release-notes/1456.md
@@ -0,0 +1,5 @@
+---
+category: Bugfix
+authors: [aleetsaiya]
+---
+Fix the mobile footer color back to the previous version
\ No newline at end of file
--
GitLab