From ca8a8174c439be6569190c5a2963f736543fdb46 Mon Sep 17 00:00:00 2001 From: Matt Fiddaman <github@m.fiddaman.uk> Date: Sat, 27 Apr 2024 17:29:47 +0100 Subject: [PATCH] Fix menuItemTextHeader contrast in dark mode (#2638) * Fix menuItemTextHeader contrast in dark mode * release note * darken menu background and change accent colour to purple in dark theme * change menu keybind accept colour to purple in midnight theme * update release note * fix menuBorder colour --- packages/desktop-client/src/style/themes/dark.ts | 10 +++++----- packages/desktop-client/src/style/themes/midnight.ts | 2 +- upcoming-release-notes/2638.md | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-) create mode 100644 upcoming-release-notes/2638.md diff --git a/packages/desktop-client/src/style/themes/dark.ts b/packages/desktop-client/src/style/themes/dark.ts index d580e723a..242711835 100644 --- a/packages/desktop-client/src/style/themes/dark.ts +++ b/packages/desktop-client/src/style/themes/dark.ts @@ -47,16 +47,16 @@ export const sidebarItemBackgroundHover = colorPalette.navy700; export const sidebarItemText = colorPalette.navy150; export const sidebarItemTextSelected = colorPalette.purple200; -export const menuBackground = colorPalette.navy600; -export const menuItemBackground = colorPalette.navy600; +export const menuBackground = colorPalette.navy800; +export const menuItemBackground = colorPalette.navy800; export const menuItemBackgroundHover = colorPalette.navy500; export const menuItemText = colorPalette.navy100; export const menuItemTextHover = colorPalette.navy50; export const menuItemTextSelected = colorPalette.purple400; -export const menuItemTextHeader = colorPalette.purple500; -export const menuBorder = colorPalette.navy800; +export const menuItemTextHeader = colorPalette.purple200; +export const menuBorder = colorPalette.navy900; export const menuBorderHover = colorPalette.purple400; -export const menuKeybindingText = colorPalette.navy500; +export const menuKeybindingText = colorPalette.purple200; export const menuAutoCompleteBackground = colorPalette.navy900; export const menuAutoCompleteBackgroundHover = colorPalette.navy600; export const menuAutoCompleteText = colorPalette.navy200; diff --git a/packages/desktop-client/src/style/themes/midnight.ts b/packages/desktop-client/src/style/themes/midnight.ts index 9a6fc4fbe..ee1ff3097 100644 --- a/packages/desktop-client/src/style/themes/midnight.ts +++ b/packages/desktop-client/src/style/themes/midnight.ts @@ -56,7 +56,7 @@ export const menuItemTextSelected = colorPalette.purple400; export const menuItemTextHeader = colorPalette.purple200; export const menuBorder = colorPalette.gray800; export const menuBorderHover = colorPalette.purple300; -export const menuKeybindingText = colorPalette.gray500; +export const menuKeybindingText = colorPalette.purple200; export const menuAutoCompleteBackground = colorPalette.gray600; export const menuAutoCompleteBackgroundHover = colorPalette.gray500; export const menuAutoCompleteText = colorPalette.gray100; diff --git a/upcoming-release-notes/2638.md b/upcoming-release-notes/2638.md new file mode 100644 index 000000000..6d49fc502 --- /dev/null +++ b/upcoming-release-notes/2638.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [matt-fidd] +--- + +Fix low contrast accent colours in dark and midnight themes -- GitLab