From c6e480e89c5ad3bbbf355becd160f31d3942c81d Mon Sep 17 00:00:00 2001
From: Jed Fox <git@jedfox.com>
Date: Fri, 21 Jul 2023 13:14:59 -0400
Subject: [PATCH] Move saveScrollWidth call to layout effect (#1366)
---
packages/desktop-client/src/components/table.tsx | 12 ++++++------
upcoming-release-notes/1366.md | 6 ++++++
2 files changed, 12 insertions(+), 6 deletions(-)
create mode 100644 upcoming-release-notes/1366.md
diff --git a/packages/desktop-client/src/components/table.tsx b/packages/desktop-client/src/components/table.tsx
index 3de76be66..b4a63e243 100644
--- a/packages/desktop-client/src/components/table.tsx
+++ b/packages/desktop-client/src/components/table.tsx
@@ -1060,12 +1060,6 @@ export const Table = forwardRef<TableHandleRef, TableProps>(
list.current?.setRowAnimation(true);
listInitialized.current = true;
}
- });
-
- function renderRow({ index, style, key }) {
- let item = items[index];
- let editing = editingId === item.id;
- let selected = isSelected && isSelected(item.id);
if (scrollContainer.current && saveScrollWidth) {
saveScrollWidth(
@@ -1075,6 +1069,12 @@ export const Table = forwardRef<TableHandleRef, TableProps>(
scrollContainer.current ? scrollContainer.current.clientWidth : 0,
);
}
+ });
+
+ function renderRow({ index, style, key }) {
+ let item = items[index];
+ let editing = editingId === item.id;
+ let selected = isSelected && isSelected(item.id);
let row = renderItem({
item,
diff --git a/upcoming-release-notes/1366.md b/upcoming-release-notes/1366.md
new file mode 100644
index 000000000..88a4c9200
--- /dev/null
+++ b/upcoming-release-notes/1366.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [j-f1]
+---
+
+Fix React warning in the console
--
GitLab