From c286f1c5f3dce70cb2a4215cd4c218aeaab24cf2 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Tue, 20 Jun 2023 20:56:23 +0100
Subject: [PATCH] :bug: remove 'we have been notified' copy (#1155)
Closes #1069
I've not actually tested this change. Which is why I'm not changing it
to direct links (as they might not work).
Instead I'm just applying a very quick patch so the message would not be
misleading anymore.
---
packages/desktop-client/src/components/manager/Import.js | 2 +-
.../desktop-client/src/components/manager/ImportActual.js | 2 +-
.../desktop-client/src/components/manager/ImportYNAB4.js | 2 +-
.../desktop-client/src/components/manager/ImportYNAB5.js | 2 +-
packages/loot-core/src/client/actions/notifications.ts | 2 +-
upcoming-release-notes/1155.md | 6 ++++++
6 files changed, 11 insertions(+), 5 deletions(-)
create mode 100644 upcoming-release-notes/1155.md
diff --git a/packages/desktop-client/src/components/manager/Import.js b/packages/desktop-client/src/components/manager/Import.js
index e7a57a43b..be9491e00 100644
--- a/packages/desktop-client/src/components/manager/Import.js
+++ b/packages/desktop-client/src/components/manager/Import.js
@@ -8,7 +8,7 @@ function getErrorMessage(error) {
case 'not-ynab4':
return 'This file is not valid. Please select a .ynab4 file';
default:
- return 'An unknown error occurred while importing. Sorry! We have been notified of this issue.';
+ return 'An unknown error occurred while importing. Please report this as a new issue on Github.';
}
}
diff --git a/packages/desktop-client/src/components/manager/ImportActual.js b/packages/desktop-client/src/components/manager/ImportActual.js
index 58aaa4ba2..4579fd2e2 100644
--- a/packages/desktop-client/src/components/manager/ImportActual.js
+++ b/packages/desktop-client/src/components/manager/ImportActual.js
@@ -19,7 +19,7 @@ function getErrorMessage(error) {
case 'invalid-metadata-file':
return 'The metadata file in the given archive is corrupted.';
default:
- return 'An unknown error occurred while importing. Sorry! We have been notified of this issue.';
+ return 'An unknown error occurred while importing. Please report this as a new issue on Github.';
}
}
diff --git a/packages/desktop-client/src/components/manager/ImportYNAB4.js b/packages/desktop-client/src/components/manager/ImportYNAB4.js
index 7f2c441ca..218e84452 100644
--- a/packages/desktop-client/src/components/manager/ImportYNAB4.js
+++ b/packages/desktop-client/src/components/manager/ImportYNAB4.js
@@ -11,7 +11,7 @@ function getErrorMessage(error) {
case 'not-ynab4':
return 'This file is not valid. Please select a compressed ynab4 zip file.';
default:
- return 'An unknown error occurred while importing. Sorry! We have been notified of this issue.';
+ return 'An unknown error occurred while importing. Please report this as a new issue on Github.';
}
}
diff --git a/packages/desktop-client/src/components/manager/ImportYNAB5.js b/packages/desktop-client/src/components/manager/ImportYNAB5.js
index 015109ab8..86a75f06a 100644
--- a/packages/desktop-client/src/components/manager/ImportYNAB5.js
+++ b/packages/desktop-client/src/components/manager/ImportYNAB5.js
@@ -20,7 +20,7 @@ function getErrorMessage(error) {
case 'not-ynab5':
return 'This file is not valid. Please select a JSON file exported from nYNAB.';
default:
- return 'An unknown error occurred while importing. Sorry! We have been notified of this issue.';
+ return 'An unknown error occurred while importing. Please report this as a new issue on Github.';
}
}
diff --git a/packages/loot-core/src/client/actions/notifications.ts b/packages/loot-core/src/client/actions/notifications.ts
index 7cc0ca1eb..86c1a1ccd 100644
--- a/packages/loot-core/src/client/actions/notifications.ts
+++ b/packages/loot-core/src/client/actions/notifications.ts
@@ -16,7 +16,7 @@ export function addGenericErrorNotification() {
type: 'error',
message:
'Something internally went wrong. You may want to restart the app if anything looks wrong. ' +
- 'We have been notified of the issue and will try to fix it soon.',
+ 'Please report this as a new issue on Github.',
});
}
diff --git a/upcoming-release-notes/1155.md b/upcoming-release-notes/1155.md
new file mode 100644
index 000000000..86619f257
--- /dev/null
+++ b/upcoming-release-notes/1155.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Remove misleading 'we have been notified' error messages
--
GitLab