From bb0ae4ebc3826b25ed10433c5872c56b5f72cb76 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Sun, 21 Jan 2024 14:55:24 +0000
Subject: [PATCH] :fire: removing unused variables (batch 2) (#2256)
---
.eslintrc.js | 1 -
.../src/browser-preload.browser.js | 10 +--
.../src/components/FatalError.tsx | 2 +-
.../src/components/FixedSizeList.tsx | 67 +++++++------------
.../src/components/ManageRules.tsx | 2 +-
.../src/components/accounts/Account.jsx | 4 +-
.../src/components/accounts/MobileAccount.jsx | 2 +-
.../src/components/budget/MobileBudget.tsx | 9 +--
.../components/budget/MobileBudgetTable.jsx | 10 +--
.../src/components/budget/SidebarCategory.tsx | 2 +-
.../src/components/budget/SidebarGroup.tsx | 6 +-
.../src/components/budget/index.tsx | 2 +-
.../budget/report/BalanceTooltip.tsx | 2 +-
.../budget/rollover/CoverTooltip.tsx | 2 +-
.../budget/rollover/TransferTooltip.tsx | 2 +-
.../rollover/budgetsummary/BudgetSummary.tsx | 2 +-
.../src/components/common/Menu.tsx | 2 +-
.../components/modals/CategoryGroupMenu.tsx | 2 +-
.../src/components/modals/CategoryMenu.tsx | 2 +-
.../src/components/modals/EditRule.jsx | 4 +-
.../src/components/modals/Notes.tsx | 2 +-
.../src/components/modals/SingleInput.tsx | 2 +-
.../payees/ManagePayeesWithData.jsx | 4 +-
.../src/components/reports/ChooseGraph.tsx | 4 --
.../src/components/reports/Header.jsx | 1 -
.../components/reports/graphs/AreaGraph.tsx | 2 +-
.../components/reports/graphs/BarGraph.tsx | 2 +-
.../reports/graphs/BarLineGraph.tsx | 5 +-
.../components/reports/graphs/DonutGraph.tsx | 2 +-
.../components/reports/graphs/LineGraph.tsx | 5 +-
.../reports/graphs/NetWorthGraph.tsx | 9 +--
.../components/reports/graphs/SankeyGraph.tsx | 2 +-
.../reports/graphs/StackedBarGraph.tsx | 2 +-
.../graphs/tableGraph/ReportTableHeader.tsx | 2 -
.../graphs/tableGraph/ReportTableTotals.tsx | 2 -
.../components/reports/reports/CashFlow.tsx | 1 -
.../spreadsheets/cash-flow-spreadsheet.tsx | 6 +-
upcoming-release-notes/2256.md | 6 ++
38 files changed, 73 insertions(+), 121 deletions(-)
create mode 100644 upcoming-release-notes/2256.md
diff --git a/.eslintrc.js b/.eslintrc.js
index bf7bb15cb..53796782d 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -57,7 +57,6 @@ module.exports = {
'@typescript-eslint/no-unused-vars': [
'warn',
{
- args: 'none',
varsIgnorePattern: '^_',
ignoreRestSiblings: true,
},
diff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.js
index 37bd1f537..ca5bc118d 100644
--- a/packages/desktop-client/src/browser-preload.browser.js
+++ b/packages/desktop-client/src/browser-preload.browser.js
@@ -51,7 +51,7 @@ global.Actual = {
window.location.reload();
},
- openFileDialog: async ({ filters = [], properties }) => {
+ openFileDialog: async ({ filters = [] }) => {
return new Promise(resolve => {
let createdElement = false;
// Attempt to reuse an already-created file input.
@@ -91,7 +91,7 @@ global.Actual = {
.uploadFile(filename, ev.target.result)
.then(() => resolve([filepath]));
};
- reader.onerror = function (ev) {
+ reader.onerror = function () {
alert('Error reading file');
};
}
@@ -107,7 +107,7 @@ global.Actual = {
});
},
- saveFile: (contents, defaultFilename, dialogTitle) => {
+ saveFile: (contents, defaultFilename) => {
const temp = document.createElement('a');
temp.style = 'display: none';
temp.download = defaultFilename;
@@ -121,9 +121,9 @@ global.Actual = {
openURLInBrowser: url => {
window.open(url, '_blank');
},
- onEventFromMain: (type, handler) => {},
+ onEventFromMain: () => {},
applyAppUpdate: () => {},
- updateAppMenu: isBudgetOpen => {},
+ updateAppMenu: () => {},
ipcConnect: () => {},
getServerSocket: async () => {
diff --git a/packages/desktop-client/src/components/FatalError.tsx b/packages/desktop-client/src/components/FatalError.tsx
index f15b68526..ebed6c72e 100644
--- a/packages/desktop-client/src/components/FatalError.tsx
+++ b/packages/desktop-client/src/components/FatalError.tsx
@@ -131,7 +131,7 @@ function SharedArrayBufferOverride() {
>
<Checkbox
checked={understand}
- onChange={_ => setUnderstand(!understand)}
+ onChange={() => setUnderstand(!understand)}
/>{' '}
I understand the risks, run Actual in the unsupported fallback mode
</label>
diff --git a/packages/desktop-client/src/components/FixedSizeList.tsx b/packages/desktop-client/src/components/FixedSizeList.tsx
index 2e74b00d5..b2257a0a0 100644
--- a/packages/desktop-client/src/components/FixedSizeList.tsx
+++ b/packages/desktop-client/src/components/FixedSizeList.tsx
@@ -2,7 +2,6 @@
import {
createRef,
PureComponent,
- type ReactElement,
type ReactNode,
type Ref,
type MutableRefObject,
@@ -11,7 +10,6 @@ import {
import memoizeOne from 'memoize-one';
-import { useResizeObserver } from '../hooks/useResizeObserver';
import { type CSSProperties } from '../style';
import { View } from './common/View';
@@ -20,16 +18,6 @@ const IS_SCROLLING_DEBOUNCE_INTERVAL = 150;
const defaultItemKey: FixedSizeListProps['itemKey'] = (index: number) => index;
-type ResizeObserverProps = {
- onResize: Parameters<typeof useResizeObserver>[0];
- children: (ref: Ref<HTMLDivElement>) => ReactElement;
-};
-
-function ResizeObserver({ onResize, children }: ResizeObserverProps) {
- const ref = useResizeObserver(onResize);
- return children(ref);
-}
-
type FixedSizeListProps = {
className?: string;
direction?: 'rtl' | 'ltr';
@@ -262,33 +250,29 @@ export class FixedSizeList extends PureComponent<
const estimatedTotalSize = this.getEstimatedTotalSize();
return (
- <ResizeObserver onResize={this.onHeaderResize}>
- {headerRef => (
- <div
- className={className}
- onScroll={this._onScrollVertical}
- ref={this._outerRefSetter}
- style={{
- height,
- width,
- overflow: 'hidden auto',
- }}
- >
- <View innerRef={headerRef}>{header}</View>
- <div
- ref={innerRef}
- style={{
- position: 'relative',
- height: estimatedTotalSize,
- width: '100%',
- pointerEvents: isScrolling ? 'none' : undefined,
- }}
- >
- {items}
- </div>
- </div>
- )}
- </ResizeObserver>
+ <div
+ className={className}
+ onScroll={this._onScrollVertical}
+ ref={this._outerRefSetter}
+ style={{
+ height,
+ width,
+ overflow: 'hidden auto',
+ }}
+ >
+ <View>{header}</View>
+ <div
+ ref={innerRef}
+ style={{
+ position: 'relative',
+ height: estimatedTotalSize,
+ width: '100%',
+ pointerEvents: isScrolling ? 'none' : undefined,
+ }}
+ >
+ {items}
+ </div>
+ </div>
);
}
@@ -305,10 +289,6 @@ export class FixedSizeList extends PureComponent<
}
};
- onHeaderResize = (rect: { height: number }) => {
- // this.setState({ headerHeight: rect.height });
- };
-
anchor() {
const itemKey = this.props.itemKey || defaultItemKey;
@@ -499,6 +479,7 @@ export class FixedSizeList extends PureComponent<
return style;
};
+ // eslint-disable-next-line @typescript-eslint/no-unused-vars
_getItemStyleCache = memoizeOne((_, __, ___) => ({}));
_getRangeToRender() {
diff --git a/packages/desktop-client/src/components/ManageRules.tsx b/packages/desktop-client/src/components/ManageRules.tsx
index 6e82621f9..0bcbfe254 100644
--- a/packages/desktop-client/src/components/ManageRules.tsx
+++ b/packages/desktop-client/src/components/ManageRules.tsx
@@ -230,7 +230,7 @@ function ManageRulesContent({
dispatch(
pushModal('edit-rule', {
rule,
- onSave: async newRule => {
+ onSave: async () => {
await loadRules();
setLoading(false);
},
diff --git a/packages/desktop-client/src/components/accounts/Account.jsx b/packages/desktop-client/src/components/accounts/Account.jsx
index 37653a025..85c586720 100644
--- a/packages/desktop-client/src/components/accounts/Account.jsx
+++ b/packages/desktop-client/src/components/accounts/Account.jsx
@@ -227,7 +227,7 @@ class AccountInternal extends PureComponent {
}
};
- const onUndo = async ({ tables, messages, undoTag }) => {
+ const onUndo = async ({ tables, messages }) => {
await maybeRefetch(tables);
// If all the messages are dealing with transactions, find the
@@ -516,7 +516,7 @@ class AccountInternal extends PureComponent {
});
}
},
- mappedData => {
+ () => {
return data;
},
);
diff --git a/packages/desktop-client/src/components/accounts/MobileAccount.jsx b/packages/desktop-client/src/components/accounts/MobileAccount.jsx
index aaaed0db5..b8d4bb6ce 100644
--- a/packages/desktop-client/src/components/accounts/MobileAccount.jsx
+++ b/packages/desktop-client/src/components/accounts/MobileAccount.jsx
@@ -43,7 +43,7 @@ const getSchedulesTransform = memoizeOne((id, hasSearch) => {
};
});
-function PreviewTransactions({ accountId, children }) {
+function PreviewTransactions({ children }) {
const scheduleData = useCachedSchedules();
if (scheduleData == null) {
diff --git a/packages/desktop-client/src/components/budget/MobileBudget.tsx b/packages/desktop-client/src/components/budget/MobileBudget.tsx
index 2a426909a..b1b59f76c 100644
--- a/packages/desktop-client/src/components/budget/MobileBudget.tsx
+++ b/packages/desktop-client/src/components/budget/MobileBudget.tsx
@@ -408,19 +408,15 @@ function BudgetInner(props: BudgetInnerProps) {
await sync();
}}
>
- {({ refreshing, onRefresh }) => (
+ {({ onRefresh }) => (
<BudgetTable
// This key forces the whole table rerender when the number
// format changes
key={numberFormat + hideFraction}
categoryGroups={categoryGroups}
- categories={categories}
type={budgetType}
month={currentMonth}
monthBounds={bounds}
- // refreshControl={
- // <RefreshControl refreshing={refreshing} onRefresh={onRefresh} />
- // }
editMode={editMode}
onEditMode={flag => setEditMode(flag)}
onShowBudgetSummary={onShowBudgetSummary}
@@ -438,9 +434,6 @@ function BudgetInner(props: BudgetInnerProps) {
onBudgetAction={applyBudgetAction}
onRefresh={onRefresh}
onSwitchBudgetType={onSwitchBudgetType}
- onSaveNotes={onSaveNotes}
- onEditGroupNotes={onEditGroupNotes}
- onEditCategoryNotes={onEditCategoryNotes}
savePrefs={savePrefs}
pushModal={pushModal}
onEditGroup={onEditGroup}
diff --git a/packages/desktop-client/src/components/budget/MobileBudgetTable.jsx b/packages/desktop-client/src/components/budget/MobileBudgetTable.jsx
index 3c2251d77..cb75b90ee 100644
--- a/packages/desktop-client/src/components/budget/MobileBudgetTable.jsx
+++ b/packages/desktop-client/src/components/budget/MobileBudgetTable.jsx
@@ -145,7 +145,7 @@ function BudgetCell({
});
}
- function onAmountClick(e) {
+ function onAmountClick() {
onEdit?.(categoryId);
}
@@ -243,7 +243,6 @@ const ExpenseCategory = memo(function ExpenseCategory({
blank,
style,
month,
- editMode,
onEdit,
isEditingBudget,
onEditBudget,
@@ -569,7 +568,6 @@ const IncomeGroupTotals = memo(function IncomeGroupTotals({
budgeted,
balance,
style,
- editMode,
onEdit,
}) {
const listItemRef = useRef();
@@ -657,7 +655,6 @@ const IncomeCategory = memo(function IncomeCategory({
balance,
month,
style,
- editMode,
onEdit,
onBudgetAction,
isEditingBudget,
@@ -1122,7 +1119,6 @@ function BudgetGroups({
export function BudgetTable({
type,
categoryGroups,
- categories,
month,
monthBounds,
editMode,
@@ -1143,9 +1139,6 @@ export function BudgetTable({
onBudgetAction,
onRefresh,
onSwitchBudgetType,
- onSaveNotes,
- onEditGroupNotes,
- onEditCategoryNotes,
savePrefs,
pushModal,
onEditGroup,
@@ -1154,7 +1147,6 @@ export function BudgetTable({
onEditCategoryBudget,
openBalanceActionMenuId,
onOpenBalanceActionMenu,
- ...props
}) {
const { width } = useResponsive();
const show3Cols = width >= 360;
diff --git a/packages/desktop-client/src/components/budget/SidebarCategory.tsx b/packages/desktop-client/src/components/budget/SidebarCategory.tsx
index 04bd471d2..8ca35fde6 100644
--- a/packages/desktop-client/src/components/budget/SidebarCategory.tsx
+++ b/packages/desktop-client/src/components/budget/SidebarCategory.tsx
@@ -154,7 +154,7 @@ export function SidebarCategory({
>
<InputCell
value={category.name}
- formatter={value => displayed}
+ formatter={() => displayed}
width="flex"
exposed={editing || temporary}
onUpdate={value => {
diff --git a/packages/desktop-client/src/components/budget/SidebarGroup.tsx b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
index c298e3d28..bbdd36b36 100644
--- a/packages/desktop-client/src/components/budget/SidebarGroup.tsx
+++ b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
@@ -27,7 +27,6 @@ type SidebarGroupProps = {
collapsed: boolean;
dragPreview?: boolean;
innerRef?: ConnectDragSource;
- borderColor?: string;
style?: CSSProperties;
onEdit?: (id: string) => void;
onSave?: (group: object) => Promise<void>;
@@ -44,7 +43,6 @@ export function SidebarGroup({
dragPreview,
innerRef,
style,
- borderColor = theme.tableBorder,
onEdit,
onSave,
onDelete,
@@ -63,7 +61,7 @@ export function SidebarGroup({
userSelect: 'none',
WebkitUserSelect: 'none',
}}
- onClick={e => {
+ onClick={() => {
onToggleCollapse(group.id);
}}
>
@@ -181,7 +179,7 @@ export function SidebarGroup({
>
<InputCell
value={group.name}
- formatter={value => displayed}
+ formatter={() => displayed}
width="flex"
exposed={editing}
onUpdate={value => {
diff --git a/packages/desktop-client/src/components/budget/index.tsx b/packages/desktop-client/src/components/budget/index.tsx
index 884567a27..3363140e6 100644
--- a/packages/desktop-client/src/components/budget/index.tsx
+++ b/packages/desktop-client/src/components/budget/index.tsx
@@ -533,7 +533,7 @@ const RolloverBudgetSummary = memo<{ month: string }>(props => {
);
});
-export function Budget(props) {
+export function Budget() {
const startMonth = useSelector(
state => state.prefs.local['budget.startMonth'],
);
diff --git a/packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx b/packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx
index 76eddb319..bf806d12b 100644
--- a/packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx
+++ b/packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx
@@ -38,7 +38,7 @@ export function BalanceTooltip({
{...tooltipProps}
>
<Menu
- onMenuSelect={type => {
+ onMenuSelect={() => {
onBudgetAction(monthIndex, 'carryover', {
category: categoryId,
flag: !carryover,
diff --git a/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx b/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx
index bd822c9cb..2f33e371f 100644
--- a/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx
+++ b/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx
@@ -48,7 +48,7 @@ export function CoverTooltip({
categoryGroups={categoryGroups}
value={null}
openOnFocus={true}
- onUpdate={id => {}}
+ onUpdate={() => {}}
onSelect={id => setCategory(id)}
inputProps={{
inputRef: node,
diff --git a/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx b/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx
index 8671a1261..0d27946f1 100644
--- a/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx
+++ b/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx
@@ -98,7 +98,7 @@ export function TransferTooltip({
categoryGroups={categoryGroups}
value={null}
openOnFocus={true}
- onUpdate={id => {}}
+ onUpdate={() => {}}
onSelect={id => setCategory(id)}
inputProps={{ onEnter: submit, placeholder: '(none)' }}
/>
diff --git a/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx b/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx
index dc66bed7a..209ab5e31 100644
--- a/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx
+++ b/packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx
@@ -35,7 +35,7 @@ export function BudgetSummary({
} = useRollover();
const [menuOpen, setMenuOpen] = useState(false);
- function onMenuOpen(e) {
+ function onMenuOpen() {
setMenuOpen(true);
}
diff --git a/packages/desktop-client/src/components/common/Menu.tsx b/packages/desktop-client/src/components/common/Menu.tsx
index dc67988c6..27c428aa3 100644
--- a/packages/desktop-client/src/components/common/Menu.tsx
+++ b/packages/desktop-client/src/components/common/Menu.tsx
@@ -163,7 +163,7 @@ export function Menu<T extends MenuItem>({
}}
onMouseEnter={() => setHoveredIndex(idx)}
onMouseLeave={() => setHoveredIndex(null)}
- onClick={e =>
+ onClick={() =>
!item.disabled && onMenuSelect && onMenuSelect(item.name)
}
>
diff --git a/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx b/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx
index bd8d3e5d1..6a1368b5a 100644
--- a/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx
+++ b/packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx
@@ -137,7 +137,7 @@ export function CategoryGroupMenu({
notes={notes?.length > 0 ? notes : 'No notes'}
editable={false}
focused={false}
- getStyle={editable => ({
+ getStyle={() => ({
...styles.mediumText,
borderRadius: 6,
...((!notes || notes.length === 0) && {
diff --git a/packages/desktop-client/src/components/modals/CategoryMenu.tsx b/packages/desktop-client/src/components/modals/CategoryMenu.tsx
index f42bb9690..2e2b79181 100644
--- a/packages/desktop-client/src/components/modals/CategoryMenu.tsx
+++ b/packages/desktop-client/src/components/modals/CategoryMenu.tsx
@@ -128,7 +128,7 @@ export function CategoryMenu({
notes={originalNotes?.length > 0 ? originalNotes : 'No notes'}
editable={false}
focused={false}
- getStyle={editable => ({
+ getStyle={() => ({
borderRadius: 6,
...((!originalNotes || originalNotes.length === 0) && {
justifySelf: 'center',
diff --git a/packages/desktop-client/src/components/modals/EditRule.jsx b/packages/desktop-client/src/components/modals/EditRule.jsx
index 661cc799e..4d42814e5 100644
--- a/packages/desktop-client/src/components/modals/EditRule.jsx
+++ b/packages/desktop-client/src/components/modals/EditRule.jsx
@@ -122,7 +122,7 @@ export function OpSelect({
);
}
-function EditorButtons({ onAdd, onDelete, style }) {
+function EditorButtons({ onAdd, onDelete }) {
return (
<>
{onDelete && (
@@ -310,7 +310,7 @@ const actionFields = [
'date',
'amount',
].map(field => [field, mapField(field)]);
-function ActionEditor({ ops, action, editorStyle, onChange, onDelete, onAdd }) {
+function ActionEditor({ action, editorStyle, onChange, onDelete, onAdd }) {
const { field, op, value, type, error, inputKey = 'initial' } = action;
return (
diff --git a/packages/desktop-client/src/components/modals/Notes.tsx b/packages/desktop-client/src/components/modals/Notes.tsx
index e36f23152..765163254 100644
--- a/packages/desktop-client/src/components/modals/Notes.tsx
+++ b/packages/desktop-client/src/components/modals/Notes.tsx
@@ -63,7 +63,7 @@ export function Notes({ modalProps, id, name, onSave }: NotesProps) {
notes={notes}
editable={true}
focused={true}
- getStyle={editable => ({
+ getStyle={() => ({
borderRadius: 6,
flex: 1,
minWidth: 0,
diff --git a/packages/desktop-client/src/components/modals/SingleInput.tsx b/packages/desktop-client/src/components/modals/SingleInput.tsx
index 8c4daef94..89f4b3347 100644
--- a/packages/desktop-client/src/components/modals/SingleInput.tsx
+++ b/packages/desktop-client/src/components/modals/SingleInput.tsx
@@ -81,7 +81,7 @@ export function SingleInput({
...styles.mediumText,
flexBasis: '50%',
}}
- onPointerUp={e => _onSubmit(value)}
+ onPointerUp={() => _onSubmit(value)}
>
{buttonText}
</Button>
diff --git a/packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx b/packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx
index 338adbb08..a828c5e73 100644
--- a/packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx
+++ b/packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx
@@ -63,7 +63,7 @@ export function ManagePayeesWithData({ initialSelectedIds }) {
};
}, []);
- async function onUndo({ tables, messages, meta, url }, scroll = false) {
+ async function onUndo({ tables, messages, meta }) {
if (!tables.includes('payees') && !tables.includes('payee_mapping')) {
return;
}
@@ -83,7 +83,7 @@ export function ManagePayeesWithData({ initialSelectedIds }) {
useEffect(() => {
if (lastUndoState.current) {
- onUndo(lastUndoState.current, true);
+ onUndo(lastUndoState.current);
}
return listen('undo-event', onUndo);
diff --git a/packages/desktop-client/src/components/reports/ChooseGraph.tsx b/packages/desktop-client/src/components/reports/ChooseGraph.tsx
index a4e0b5b21..a3149c391 100644
--- a/packages/desktop-client/src/components/reports/ChooseGraph.tsx
+++ b/packages/desktop-client/src/components/reports/ChooseGraph.tsx
@@ -26,7 +26,6 @@ type ChooseGraphProps = {
graphType: string;
balanceType: string;
groupBy: string;
- scrollWidth?: number;
setScrollWidth?: (value: number) => void;
months?: Month[];
viewLabels?: boolean;
@@ -40,7 +39,6 @@ export function ChooseGraph({
graphType,
balanceType,
groupBy,
- scrollWidth,
setScrollWidth,
months,
viewLabels,
@@ -139,7 +137,6 @@ export function ChooseGraph({
headerScrollRef={headerScrollRef}
handleScroll={handleScroll}
interval={mode === 'time' && data.monthData}
- scrollWidth={scrollWidth}
groupBy={groupBy}
balanceType={balanceType}
compact={compact}
@@ -158,7 +155,6 @@ export function ChooseGraph({
<ReportTableTotals
totalScrollRef={totalScrollRef}
handleScroll={handleScroll}
- scrollWidth={scrollWidth}
data={data}
mode={mode}
balanceTypeOp={balanceTypeOp}
diff --git a/packages/desktop-client/src/components/reports/Header.jsx b/packages/desktop-client/src/components/reports/Header.jsx
index 34188780b..e3231f8d6 100644
--- a/packages/desktop-client/src/components/reports/Header.jsx
+++ b/packages/desktop-client/src/components/reports/Header.jsx
@@ -75,7 +75,6 @@ export function Header({
onDeleteFilter,
onCondOpChange,
headerPrefixItems,
- selectGraph,
}) {
const location = useLocation();
const path = location.pathname;
diff --git a/packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx b/packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx
index 26faf6cd8..28b47e352 100644
--- a/packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx
@@ -173,7 +173,7 @@ export function AreaGraph({
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
data.monthData && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx b/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx
index e17171b56..7f4f9ec3b 100644
--- a/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/BarGraph.tsx
@@ -167,7 +167,7 @@ export function BarGraph({
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
data[splitData] && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx b/packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx
index fe659df81..26e823288 100644
--- a/packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/BarLineGraph.tsx
@@ -33,10 +33,9 @@ type PayloadItem = {
type CustomTooltipProps = {
active?: boolean;
payload?: PayloadItem[];
- label?: string;
};
-const CustomTooltip = ({ active, payload, label }: CustomTooltipProps) => {
+const CustomTooltip = ({ active, payload }: CustomTooltipProps) => {
if (active && payload && payload.length) {
return (
<div
@@ -88,7 +87,7 @@ export function BarLineGraph({ style, graphData, compact }: BarLineGraphProps) {
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
graphData && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx b/packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx
index 6a69bb2ec..6fb3ebc03 100644
--- a/packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx
@@ -157,7 +157,7 @@ export function DonutGraph({
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
data[splitData] && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/LineGraph.tsx b/packages/desktop-client/src/components/reports/graphs/LineGraph.tsx
index 4cba1f3e7..819528439 100644
--- a/packages/desktop-client/src/components/reports/graphs/LineGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/LineGraph.tsx
@@ -32,10 +32,9 @@ type PayloadItem = {
type CustomTooltipProps = {
active?: boolean;
payload?: PayloadItem[];
- label?: string;
};
-const CustomTooltip = ({ active, payload, label }: CustomTooltipProps) => {
+const CustomTooltip = ({ active, payload }: CustomTooltipProps) => {
if (active && payload && payload.length) {
return (
<div
@@ -87,7 +86,7 @@ export function LineGraph({ style, graphData, compact }: LineGraphProps) {
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
graphData && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx b/packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx
index 9e9eb3fad..f3974f7e4 100644
--- a/packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx
@@ -22,16 +22,12 @@ type NetWorthGraphProps = {
style?: CSSProperties;
graphData;
compact: boolean;
- domain?: {
- y?: [number, number];
- };
};
export function NetWorthGraph({
style,
graphData,
compact,
- domain,
}: NetWorthGraphProps) {
const tickFormatter = tick => {
return `${Math.round(tick).toLocaleString()}`; // Formats the tick values as strings with commas
@@ -66,11 +62,10 @@ export function NetWorthGraph({
type CustomTooltipProps = {
active?: boolean;
payload?: PayloadItem[];
- label?: string;
};
// eslint-disable-next-line react/no-unstable-nested-components
- const CustomTooltip = ({ active, payload, label }: CustomTooltipProps) => {
+ const CustomTooltip = ({ active, payload }: CustomTooltipProps) => {
if (active && payload && payload.length) {
return (
<div
@@ -113,7 +108,7 @@ export function NetWorthGraph({
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
graphData && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx b/packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx
index d079a1a40..5f97bfcba 100644
--- a/packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx
@@ -114,7 +114,7 @@ export function SankeyGraph({ style, data, compact }: SankeyProps) {
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) => (
+ {width => (
<ResponsiveContainer>
<Sankey
data={sankeyData}
diff --git a/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx b/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx
index 812be419a..16b584667 100644
--- a/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx
@@ -142,7 +142,7 @@ export function StackedBarGraph({
...(compact && { height: 'auto' }),
}}
>
- {(width, height, portalHost) =>
+ {(width, height) =>
data.monthData && (
<ResponsiveContainer>
<div>
diff --git a/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx b/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx
index ea81dc534..4bb20248c 100644
--- a/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx
@@ -9,7 +9,6 @@ import { View } from '../../../common/View';
import { Row, Cell } from '../../../table';
type ReportTableHeaderProps = {
- scrollWidth?: number;
groupBy: string;
interval?: DataEntity[];
balanceType: string;
@@ -19,7 +18,6 @@ type ReportTableHeaderProps = {
};
export function ReportTableHeader({
- scrollWidth,
groupBy,
interval,
balanceType,
diff --git a/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx b/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx
index 784f6054e..5153ae1b0 100644
--- a/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx
+++ b/packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx
@@ -15,7 +15,6 @@ import { Row, Cell } from '../../../table';
type ReportTableTotalsProps = {
data: GroupedEntity;
- scrollWidth?: number;
balanceTypeOp: string;
mode: string;
monthsCount: number;
@@ -26,7 +25,6 @@ type ReportTableTotalsProps = {
export function ReportTableTotals({
data,
- scrollWidth,
balanceTypeOp,
mode,
monthsCount,
diff --git a/packages/desktop-client/src/components/reports/reports/CashFlow.tsx b/packages/desktop-client/src/components/reports/reports/CashFlow.tsx
index e1ad6356c..70f195efd 100644
--- a/packages/desktop-client/src/components/reports/reports/CashFlow.tsx
+++ b/packages/desktop-client/src/components/reports/reports/CashFlow.tsx
@@ -110,7 +110,6 @@ export function CashFlow(): JSX.Element {
conditionsOp={conditionsOp}
onCondOpChange={onCondOpChange}
headerPrefixItems={undefined}
- selectGraph={undefined}
/>
<View
style={{
diff --git a/packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx b/packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx
index d2b804320..7048e0a1d 100644
--- a/packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx
+++ b/packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx
@@ -58,7 +58,7 @@ export function cashFlowByDate(
});
const conditionsOpKey = conditionsOp === 'or' ? '$or' : '$and';
- function makeQuery(where) {
+ function makeQuery() {
const query = q('transactions')
.filter({
[conditionsOpKey]: filters,
@@ -99,8 +99,8 @@ export function cashFlowByDate(
'account.offbudget': false,
})
.calculate({ $sum: '$amount' }),
- makeQuery('amount > 0').filter({ amount: { $gt: 0 } }),
- makeQuery('amount < 0').filter({ amount: { $lt: 0 } }),
+ makeQuery().filter({ amount: { $gt: 0 } }),
+ makeQuery().filter({ amount: { $lt: 0 } }),
],
data => {
setData(recalculate(data, start, end, isConcise));
diff --git a/upcoming-release-notes/2256.md b/upcoming-release-notes/2256.md
new file mode 100644
index 000000000..02d56a0c7
--- /dev/null
+++ b/upcoming-release-notes/2256.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Code clean-up: removing unused variables (pt.2)
--
GitLab