diff --git a/packages/desktop-client/src/components/common/Menu.tsx b/packages/desktop-client/src/components/common/Menu.tsx index a948ca5ec4e086d83c25e1ed2b06f4f67cb6b99d..38d0b9a9c3a106cf9b2dfd39557ea997974a7451 100644 --- a/packages/desktop-client/src/components/common/Menu.tsx +++ b/packages/desktop-client/src/components/common/Menu.tsx @@ -173,7 +173,11 @@ export function Menu<T extends MenuItem>({ }} onPointerEnter={() => setHoveredIndex(idx)} onPointerLeave={() => setHoveredIndex(null)} - onClick={() => !item.disabled && onMenuSelect?.(item.name)} + onClick={() => + !item.disabled && + item.toggle === undefined && + onMenuSelect?.(item.name) + } > {/* Force it to line up evenly */} {item.toggle === undefined ? ( @@ -200,7 +204,9 @@ export function Menu<T extends MenuItem>({ onColor={theme.pageTextPositive} style={{ marginLeft: 5 }} onToggle={() => - !item.disabled && item.toggle && onMenuSelect?.(item.name) + !item.disabled && + item.toggle !== undefined && + onMenuSelect?.(item.name) } /> </> diff --git a/upcoming-release-notes/2553.md b/upcoming-release-notes/2553.md new file mode 100644 index 0000000000000000000000000000000000000000..2ce0e562ce1f077b176f7b09b0e804e6d9e4dd8f --- /dev/null +++ b/upcoming-release-notes/2553.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [carkom] +--- + +This fixes a regression that broke toggle menu items.