From b385c715efde9a048f34262a8392ba425acd3a88 Mon Sep 17 00:00:00 2001
From: youngcw <calebyoung94@gmail.com>
Date: Mon, 18 Dec 2023 08:00:30 -0700
Subject: [PATCH] [Goals]: don't run templates in hidden groups (#2100)
* don't run templates in hidden groups
* note
* lint
---
packages/loot-core/src/server/budget/goaltemplates.ts | 7 ++++++-
upcoming-release-notes/2100.md | 6 ++++++
2 files changed, 12 insertions(+), 1 deletion(-)
create mode 100644 upcoming-release-notes/2100.md
diff --git a/packages/loot-core/src/server/budget/goaltemplates.ts b/packages/loot-core/src/server/budget/goaltemplates.ts
index 45d8fcb4d..6c71ee2a1 100644
--- a/packages/loot-core/src/server/budget/goaltemplates.ts
+++ b/packages/loot-core/src/server/budget/goaltemplates.ts
@@ -44,7 +44,12 @@ export function runCheckTemplates() {
async function getCategories() {
return await db.all(
- 'SELECT * FROM v_categories WHERE tombstone = 0 AND hidden = 0',
+ `
+ SELECT categories.* FROM categories
+ INNER JOIN category_groups on categories.cat_group = category_groups.id
+ WHERE categories.tombstone = 0 AND categories.hidden = 0
+ AND category_groups.hidden = 0
+ `,
);
}
diff --git a/upcoming-release-notes/2100.md b/upcoming-release-notes/2100.md
new file mode 100644
index 000000000..228149363
--- /dev/null
+++ b/upcoming-release-notes/2100.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [youngcw]
+---
+
+Goals: Don't run templates on non-hidden categories inside of hidden groups
--
GitLab