From ada9e7da31a045001b7ecd323ed6b383e8264160 Mon Sep 17 00:00:00 2001
From: Ryan Bianchi <1435081+qedi-r@users.noreply.github.com>
Date: Sat, 30 Mar 2024 16:03:20 -0400
Subject: [PATCH] [WIP] Fix custom reports cold-reload crash (#2528)
* when custom reports were cold-reloaded, the selections would be null crashing the page
* add release notes for PR
* fix typo in release note file name
---
.../src/components/reports/CategorySelector.tsx | 5 +++++
upcoming-release-notes/2528.md | 6 ++++++
2 files changed, 11 insertions(+)
create mode 100644 upcoming-release-notes/2528.md
diff --git a/packages/desktop-client/src/components/reports/CategorySelector.tsx b/packages/desktop-client/src/components/reports/CategorySelector.tsx
index e7574a0f6..d9639de36 100644
--- a/packages/desktop-client/src/components/reports/CategorySelector.tsx
+++ b/packages/desktop-client/src/components/reports/CategorySelector.tsx
@@ -45,10 +45,15 @@ export function CategorySelector({
filteredGroup(categoryGroup).map(category => selectAll.push(category)),
);
+ if (selectedCategories === undefined) {
+ selectedCategories = categoryGroups.flatMap(cg => cg.categories);
+ }
+
const selectedCategoryMap = useMemo(
() => selectedCategories.map(selected => selected.id),
[selectedCategories],
);
+
const allCategoriesSelected = selectAll.every(category =>
selectedCategoryMap.includes(category.id),
);
diff --git a/upcoming-release-notes/2528.md b/upcoming-release-notes/2528.md
new file mode 100644
index 000000000..e348ce251
--- /dev/null
+++ b/upcoming-release-notes/2528.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [qedi-r]
+---
+
+Fix custom report page cold-reload crash.
--
GitLab