From 9f72b4382676aed233086c52eb93ded2089fc5f2 Mon Sep 17 00:00:00 2001
From: Michael Clark <5285928+MikesGlitch@users.noreply.github.com>
Date: Tue, 9 Jul 2024 18:08:23 +0100
Subject: [PATCH] :electron: Remove unneded files (#3014)
---
packages/desktop-electron/index.ts | 2 -
packages/desktop-electron/server.ts | 2 -
packages/desktop-electron/setRequireHook.js | 3 -
packages/desktop-electron/signWindowsHook.js | 58 --------------------
upcoming-release-notes/3014.md | 6 ++
5 files changed, 6 insertions(+), 65 deletions(-)
delete mode 100644 packages/desktop-electron/setRequireHook.js
delete mode 100644 packages/desktop-electron/signWindowsHook.js
create mode 100644 upcoming-release-notes/3014.md
diff --git a/packages/desktop-electron/index.ts b/packages/desktop-electron/index.ts
index c71a02126..bb75cbf69 100644
--- a/packages/desktop-electron/index.ts
+++ b/packages/desktop-electron/index.ts
@@ -24,8 +24,6 @@ import {
listen as listenToWindowState,
} from './window-state';
-import './setRequireHook';
-
import './security';
Module.globalPaths.push(__dirname + '/..');
diff --git a/packages/desktop-electron/server.ts b/packages/desktop-electron/server.ts
index 4ca016ca9..a49e14d40 100644
--- a/packages/desktop-electron/server.ts
+++ b/packages/desktop-electron/server.ts
@@ -3,8 +3,6 @@ import Module from 'module';
// @ts-strict-ignore
import fetch from 'node-fetch';
-import './setRequireHook';
-
Module.globalPaths.push(__dirname + '/..');
global.fetch = fetch;
diff --git a/packages/desktop-electron/setRequireHook.js b/packages/desktop-electron/setRequireHook.js
deleted file mode 100644
index ad66c6b9e..000000000
--- a/packages/desktop-electron/setRequireHook.js
+++ /dev/null
@@ -1,3 +0,0 @@
-require.extensions['.electron.js'] = function (module, filename) {
- return require.extensions['.js'](module, filename);
-};
diff --git a/packages/desktop-electron/signWindowsHook.js b/packages/desktop-electron/signWindowsHook.js
deleted file mode 100644
index dff7ebff1..000000000
--- a/packages/desktop-electron/signWindowsHook.js
+++ /dev/null
@@ -1,58 +0,0 @@
-const { execSync } = require('child_process');
-
-const {
- SIGN_TOOL_PATH = 'C:\\Program Files (x86)\\Windows Kits\\10\\bin\\x64\\signtool.exe',
- TIMESTAMP_SERVER = 'http://timestamp.digicert.com',
-} = process.env;
-
-const SITE = 'https://actualbudget.com/';
-
-const importPfx = (certPath, password) => {
- /* eslint-disable rulesdir/typography */
- const command = [
- ['certutil'],
- ['-f'],
- ['-p', `"${password}"`],
- ['-importPfx', 'My', `"${certPath}"`, 'NoRoot'],
- ]
- .map(sub => sub.join(' '))
- .join(' ');
- /* eslint-enable rulesdir/typography */
-
- try {
- execSync(command, { stdio: 'inherit' });
- } catch {
- console.error('Unable to import certificate');
- }
-};
-
-const signBinary = (path, name) => {
- /* eslint-disable rulesdir/typography */
- const command = [
- [`"${SIGN_TOOL_PATH}"`],
- ['sign'],
- ['/a'],
- ['/s', 'My'],
- ['/sm'],
- ['/t', `"${TIMESTAMP_SERVER}"`],
- ['/d', `"${name}"`],
- ['/du', `"${SITE}"`],
- [`"${path}"`],
- ]
- .map(sub => sub.join(' '))
- .join(' ');
- /* eslint-enable rulesdir/typography */
-
- try {
- execSync(command, { stdio: 'inherit' });
- } catch {
- console.error(`Signing ${path} failed`);
- }
-};
-
-exports.default = ({ path, name, cscInfo: { file, password } = {} }) => {
- if (!file) return;
-
- importPfx(file, password);
- signBinary(path, name, file);
-};
diff --git a/upcoming-release-notes/3014.md b/upcoming-release-notes/3014.md
new file mode 100644
index 000000000..7a5736313
--- /dev/null
+++ b/upcoming-release-notes/3014.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MikesGlitch]
+---
+
+Remove unused files from Electron app
--
GitLab