From 98a32432ef7e310e42681b7a77b3fd0afb481756 Mon Sep 17 00:00:00 2001
From: Jed Fox <git@jedfox.com>
Date: Fri, 7 Apr 2023 16:15:00 -0400
Subject: [PATCH] Disable ESLint in CI again (#869)
This should speed up builds in CI, and must not have gotten caught when
upgrading `react-scripts`.
ref: arackaf/customize-cra#278
---
packages/desktop-client/config-overrides.js | 6 ++++--
upcoming-release-notes/869.md | 6 ++++++
2 files changed, 10 insertions(+), 2 deletions(-)
create mode 100644 upcoming-release-notes/869.md
diff --git a/packages/desktop-client/config-overrides.js b/packages/desktop-client/config-overrides.js
index 1715f4fbe..68e9ad7b2 100644
--- a/packages/desktop-client/config-overrides.js
+++ b/packages/desktop-client/config-overrides.js
@@ -2,16 +2,18 @@ const path = require('path');
const {
addWebpackResolve,
- disableEsLint,
override,
overrideDevServer,
babelInclude,
} = require('customize-cra');
+if (process.env.CI) {
+ process.env.DISABLE_ESLINT_PLUGIN = 'true';
+}
+
module.exports = {
webpack: override(
babelInclude([path.resolve('src'), path.resolve('../loot-core')]),
- process.env.CI && disableEsLint(),
addWebpackResolve({
extensions: [
...(process.env.IS_GENERIC_BROWSER
diff --git a/upcoming-release-notes/869.md b/upcoming-release-notes/869.md
new file mode 100644
index 000000000..d6fa18e28
--- /dev/null
+++ b/upcoming-release-notes/869.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [j-f1]
+---
+
+Disable ESLint when building in CI (since we have a separate linting job)
--
GitLab