diff --git a/packages/desktop-client/src/components/manager/ConfigServer.tsx b/packages/desktop-client/src/components/manager/ConfigServer.tsx index 8934024d207ddc63628430e6cec55c65d51c3cea..e61887a8e21c8e15440803e7a4c2266c70600eb7 100644 --- a/packages/desktop-client/src/components/manager/ConfigServer.tsx +++ b/packages/desktop-client/src/components/manager/ConfigServer.tsx @@ -49,7 +49,7 @@ export default function ConfigServer() { let { error } = await setServerUrl(url); if ( - error === 'network-failure' && + ['network-failure', 'get-server-failure'].includes(error) && !url.startsWith('http://') && !url.startsWith('https://') ) { diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.ts index d76af67ee116dc4dde5921004506ae36fc9a031b..ac739846511bbed32a58e9f80c795614c2c40126 100644 --- a/packages/loot-core/src/server/main.ts +++ b/packages/loot-core/src/server/main.ts @@ -1628,8 +1628,12 @@ handlers['get-did-bootstrap'] = async function () { handlers['subscribe-needs-bootstrap'] = async function ({ url, }: { url? } = {}) { - if (!getServer(url)) { - return { bootstrapped: true, hasServer: false }; + try { + if (!getServer(url)) { + return { bootstrapped: true, hasServer: false }; + } + } catch (err) { + return { error: 'get-server-failure' }; } let res; diff --git a/packages/loot-core/src/server/server-config.ts b/packages/loot-core/src/server/server-config.ts index 623cced37c47e46b7f8b52aa5304ae440887a45b..ab0e72096dca0e8bd7637273b20d1f707489f485 100644 --- a/packages/loot-core/src/server/server-config.ts +++ b/packages/loot-core/src/server/server-config.ts @@ -32,8 +32,7 @@ export function getServer(url?: string): ServerConfig | null { SYNC_SERVER: joinURL(url, '/sync'), SIGNUP_SERVER: joinURL(url, '/account'), PLAID_SERVER: joinURL(url, '/plaid'), - // TODO: change to use `/gocardless` after v23.8.0 - GOCARDLESS_SERVER: joinURL(url, '/nordigen'), + GOCARDLESS_SERVER: joinURL(url, '/gocardless'), }; } return config; diff --git a/upcoming-release-notes/1657.md b/upcoming-release-notes/1657.md new file mode 100644 index 0000000000000000000000000000000000000000..50be64716e14e126df6bc0bee3215532498da889 --- /dev/null +++ b/upcoming-release-notes/1657.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MatissJanis] +--- + +Fix signup page not allowing to use domains without protocol