From 81446fb4ef07bba4b1eac6e1d28426a7b6d69fba Mon Sep 17 00:00:00 2001 From: Jed Fox <git@jedfox.com> Date: Mon, 31 Jul 2023 00:08:52 -0700 Subject: [PATCH] Remove no-op applyFilter call (#1430) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `applyFilter` exits early if the filter is unchanged, so this call doesn’t do anything. --- packages/desktop-client/src/components/payees/index.js | 3 +-- upcoming-release-notes/1430.md | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 upcoming-release-notes/1430.md diff --git a/packages/desktop-client/src/components/payees/index.js b/packages/desktop-client/src/components/payees/index.js index 6b34b408b..ba8e1ec5f 100644 --- a/packages/desktop-client/src/components/payees/index.js +++ b/packages/desktop-client/src/components/payees/index.js @@ -518,8 +518,7 @@ export const ManagePayees = forwardRef( style={{ marginRight: 10 }} onClick={() => { setOrphanedOnly(!orphanedOnly); - const filterInput = document.getElementById('filter-input'); - applyFilter(filterInput.value); + applyFilter(filter); tableNavigator.onEdit(null); }} > diff --git a/upcoming-release-notes/1430.md b/upcoming-release-notes/1430.md new file mode 100644 index 000000000..ca8179ec6 --- /dev/null +++ b/upcoming-release-notes/1430.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [j-f1] +--- + +Remove no-op `applyFilter` call -- GitLab