From 601c9aa7dff791b7b9b179c0fd23fa0e81f9fdc8 Mon Sep 17 00:00:00 2001
From: shall0pass <20625555+shall0pass@users.noreply.github.com>
Date: Mon, 4 Mar 2024 14:45:15 -0600
Subject: [PATCH] [End of Month Cleanup] Remove automatic funding of rollover
categories (#2409)
* remove automatic funding of rollover categories
* note
---
.../src/server/budget/cleanup-template.ts | 42 -------------------
upcoming-release-notes/2409.md | 6 +++
2 files changed, 6 insertions(+), 42 deletions(-)
create mode 100644 upcoming-release-notes/2409.md
diff --git a/packages/loot-core/src/server/budget/cleanup-template.ts b/packages/loot-core/src/server/budget/cleanup-template.ts
index 6369b4ddd..e9b431dc7 100644
--- a/packages/loot-core/src/server/budget/cleanup-template.ts
+++ b/packages/loot-core/src/server/budget/cleanup-template.ts
@@ -118,48 +118,6 @@ async function processCleanup(month: string): Promise<Notification> {
}
}
- //fund rollover categories after non-rollover categories
- for (let c = 0; c < categories.length; c++) {
- const category = categories[c];
- const budgetAvailable = await getSheetValue(sheetName, `to-budget`);
- const balance = await getSheetValue(sheetName, `leftover-${category.id}`);
- const budgeted = await getSheetValue(sheetName, `budget-${category.id}`);
- const to_budget = budgeted + Math.abs(balance);
- const categoryId = category.id;
- let carryover = await db.first(
- `SELECT carryover FROM zero_budgets WHERE month = ? and category = ?`,
- [db_month, categoryId],
- );
-
- if (carryover === null) {
- carryover = { carryover: 0 };
- }
-
- if (
- balance < 0 &&
- Math.abs(balance) <= budgetAvailable &&
- !category.is_income &&
- carryover.carryover === 1
- ) {
- await setBudget({
- category: category.id,
- month,
- amount: to_budget,
- });
- } else if (
- balance < 0 &&
- !category.is_income &&
- carryover.carryover === 1 &&
- Math.abs(balance) > budgetAvailable
- ) {
- await setBudget({
- category: category.id,
- month,
- amount: budgeted + budgetAvailable,
- });
- }
- }
-
const budgetAvailable = await getSheetValue(sheetName, `to-budget`);
if (budgetAvailable <= 0) {
warnings.push('No funds are available to reallocate.');
diff --git a/upcoming-release-notes/2409.md b/upcoming-release-notes/2409.md
new file mode 100644
index 000000000..dba374307
--- /dev/null
+++ b/upcoming-release-notes/2409.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [shall0pass]
+---
+
+End of month cleanup - revert logic introduced in 2295. Ignore rollover categories.
--
GitLab