From 4d0e9cadd3858cac9fba9628393240b17446faab Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins <matiss@mja.lv> Date: Thu, 6 Apr 2023 20:44:15 +0100 Subject: [PATCH] :bug: (autocomplete) height of the input box (#862) --- .../src/components/accounts/Filters.js | 17 +---------------- .../autocomplete/autocomplete-styles.js | 3 ++- upcoming-release-notes/862.md | 6 ++++++ 3 files changed, 9 insertions(+), 17 deletions(-) create mode 100644 upcoming-release-notes/862.md diff --git a/packages/desktop-client/src/components/accounts/Filters.js b/packages/desktop-client/src/components/accounts/Filters.js index 036642186..b0a552258 100644 --- a/packages/desktop-client/src/components/accounts/Filters.js +++ b/packages/desktop-client/src/components/accounts/Filters.js @@ -244,7 +244,7 @@ function ConfigureField({ field={field} subfield={subfield} type={type === 'id' && op === 'contains' ? 'string' : type} - value={normalizeValue(value, op === 'oneOf')} + value={value} multi={op === 'oneOf'} style={{ marginTop: 10 }} onChange={v => dispatch({ type: 'set-value', value: v })} @@ -530,18 +530,3 @@ export function AppliedFilters({ filters, editingFilter, onUpdate, onDelete }) { </View> ); } - -function normalizeValue(value, isMulti) { - if (isMulti) { - if (Array.isArray(value)) { - return value; - } - return value.split(', '); - } - - if (Array.isArray(value)) { - return value.join(', '); - } - - return value; -} diff --git a/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js b/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js index 66eb88ebe..ae16c2827 100644 --- a/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js +++ b/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js @@ -10,7 +10,8 @@ const colourStyles = { outline: 0, marginLeft: -1, marginRight: 1, - padding: '6px 2px', + padding: '5px 2px', + fontSize: '13px', minHeight: 'auto', }), input: styles => ({ diff --git a/upcoming-release-notes/862.md b/upcoming-release-notes/862.md new file mode 100644 index 000000000..a77560520 --- /dev/null +++ b/upcoming-release-notes/862.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MatissJanis] +--- + +Autocomplete: styling fixes -- GitLab