From 48f5880f1dc260ff8a791cdb87aa4ce947df54f6 Mon Sep 17 00:00:00 2001
From: Michael Clark <5285928+MikesGlitch@users.noreply.github.com>
Date: Tue, 25 Jun 2024 17:38:39 +0100
Subject: [PATCH] :electron: Fix "Export" function on desktop app (#2925)
* fix electron export file
* add release notes
---
packages/desktop-electron/index.js | 6 +++---
upcoming-release-notes/2925.md | 6 ++++++
2 files changed, 9 insertions(+), 3 deletions(-)
create mode 100644 upcoming-release-notes/2925.md
diff --git a/packages/desktop-electron/index.js b/packages/desktop-electron/index.js
index 909a0cc7f..f3b2fca55 100644
--- a/packages/desktop-electron/index.js
+++ b/packages/desktop-electron/index.js
@@ -309,12 +309,12 @@ ipcMain.handle('open-file-dialog', (event, { filters, properties }) => {
ipcMain.handle(
'save-file-dialog',
- (event, { title, defaultPath, fileContents }) => {
- const fileLocation = dialog.showSaveDialogSync({ title, defaultPath });
+ async (event, { title, defaultPath, fileContents }) => {
+ const fileLocation = await dialog.showSaveDialog({ title, defaultPath });
return new Promise((resolve, reject) => {
if (fileLocation) {
- fs.writeFile(fileLocation, fileContents, error => {
+ fs.writeFile(fileLocation.filePath, fileContents, error => {
return reject(error);
});
}
diff --git a/upcoming-release-notes/2925.md b/upcoming-release-notes/2925.md
new file mode 100644
index 000000000..f588b238b
--- /dev/null
+++ b/upcoming-release-notes/2925.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MikesGlitch]
+---
+
+Fixes "Export data" not saving the file in Electron app on Linux
--
GitLab